Summary:ASTERISK-18803: [patch] ast_indicate(chan, -1) don't stop playing tones
Reporter:Alexander Anikin (may213)Labels:patch
Date Opened:2011-11-01 17:00:14Date Closed:
Versions:SVN 13.18.4 Frequency of
Environment:Attachments:( 0) 18803-channel.c.diff
Description:ast_indicate function must call ast_stop_playtones with negative condition argument, but don't call ast_stop_playtones if indicate function of channel driver return zero result.

As front side effect of this app_queue won't work with r (ringing instead of musiconhold) parameter and caller on dahdi channel.
Queue agent answer call but caller hear ringing tone instead of agent because generator isn't removed on the channel.

Comments:By: Alexander Anikin (may213) 2011-11-01 17:02:06.268-0500

I suggest that problem can have effect on another apps not only app_queue

By: Alexander Anikin (may213) 2011-11-01 17:10:43.826-0500

The patch is trivial and uploaded.
It change place of negative condition arg processing before processing zero result return by channel indicate function.