| Summary: | ASTERISK-18738: 1.8.8.0-rc2: chan_h323 no longer built by default | ||||
| Reporter: | Paul Belanger (pabelanger) | Labels: | regression | ||
| Date Opened: | 2011-10-19 11:27:17 | Date Closed: | 2011-11-14 15:57:14.000-0600 | ||
| Priority: | Major | Regression? | Yes | ||
| Status: | Closed/Complete | Components: | Core/BuildSystem | ||
| Versions: | 1.8.8.0 | Frequency of Occurrence | |||
| Related Issues: |
| ||||
| Environment: | Attachments: | ( 0) menuselect-defaultenabled2.diff | |||
| Description: | This is a regression from 1.8.7.0 and looks to be related to the recent menuselect changes. Steps to reproduce $ tar zxvf asterisk-1.8.8.0-rc2 $ cd asterisk-1.8.8.0-rc2 $ ./configure $ make menuselect.makeopts $ vi menuselect.makeopts chan_h323 is disabled | ||||
| Comments: | By: Paul Belanger (pabelanger) 2011-10-19 11:36:32.595-0500 Here is a diff of the files, you can ignore the changes to TESTSUITE {noformat} pabelanger@lucid:~/downloads$ diff -Nua asterisk-1.8.7.0/menuselect.makeopts asterisk-1.8.8.0-rc2/menuselect.makeopts --- asterisk-1.8.7.0/menuselect.makeopts 2011-10-19 12:33:37.652593382 -0400 +++ asterisk-1.8.8.0-rc2/menuselect.makeopts 2011-10-19 12:32:14.572588805 -0400 @@ -3,7 +3,7 @@ MENUSELECT_BRIDGES= MENUSELECT_CDR= MENUSELECT_CEL= -MENUSELECT_CHANNELS=chan_console chan_misdn chan_nbs chan_usbradio +MENUSELECT_CHANNELS=chan_console chan_h323 chan_misdn chan_nbs chan_usbradio MENUSELECT_CODECS=codec_ilbc MENUSELECT_FORMATS= MENUSELECT_FUNCS= @@ -26,21 +26,27 @@ MENUSELECT_DEPSFAILED=MENUSELECT_RES=res_srtp MENUSELECT_DEPSFAILED=MENUSELECT_RES=res_timing_kqueue MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_acl +MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_amihooks MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_aoc MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_app MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_ast_format_str_reduce MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_astobj2 MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_db MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_devicestate +MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_dlinklists MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_event MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_expr MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_func_file MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_gosub MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_heap +MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_linkedlists +MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_locale +MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_logger MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_netsock2 MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_pbx MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_poll MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_sched +MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_security_events MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_skel MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_stringfields MENUSELECT_DEPSFAILED=MENUSELECT_TESTS=test_strings {noformat} By: Paul Belanger (pabelanger) 2011-10-19 11:53:56.459-0500 Another way, {noformat} $ ./configure $ make menuselect (confirm chan_h323 is enabled, then exit without saving) $ make $ make install $ ls /usr/lib/asterisk/modules/ | grep chan_h323.so {noformat} chan_h323 is missing By: David Vossel (dvossel) 2011-10-31 16:51:44.428-0500 I thought chan_h323 wasn't built by default because it is depreciated. By: Leif Madsen (lmadsen) 2011-11-01 07:53:21.578-0500 His second note seems to indicate you can't build it at all though. By: David Vossel (dvossel) 2011-11-01 09:41:45.108-0500 built for me when I selected it in menuselect. By: Jason Parker (jparker) 2011-11-01 10:01:46.389-0500 Based on the comment about not being built by default because it's deprecated...do we even care? This should not be a blocker for 10. I was sure this got fixed pretty much immediately after this issue got opened, but I can't find the commit in menuselect now. The issue is that defaultenabled=yes on a module that would already have been defaultenabled caused it to be disabled. By: Jason Parker (jparker) 2011-11-01 10:38:16.872-0500 This should fix the issue with chan_h323 in 1.8. You'll need to run `make dist-clean` (or use a completely fresh checkout). By: Matt Jordan (mjordan) 2011-11-14 15:57:14.315-0600 Closed by qwell in r971 of menuselect | ||||