Summary:ASTERISK-18723: HANGUP agi message does not show up properly in "agi set debug on" output
Reporter:James Van Vleet (jvanvleet)Labels:
Date Opened:2011-10-14 12:25:23Date Closed:2011-11-15 14:17:15.000-0600
Versions:SVN Frequency of
Environment:Attachments:( 0) jira_asterisk_18723_v1.8.patch
Description:When debugging AGI the HANGUP command does not show up in the debug logs.  

It appears the "send" on line 3490 and 3605 of res_agi.c just needs to be changed to use ast_agi_send instead.

However, I am not clear why just these two lines were passed over so perhaps a ast_verbose on agidebug is more appropriate.

Not having this debug line print caused much pain and suffering debugging an issue in the Asterisk::AGI Perl module.  :-)

Comments:By: Richard Mudgett (rmudgett) 2011-11-07 18:29:31.064-0600

[^jira_asterisk_18723_v1.8.patch] changes the indicated lines to use ast_agi_send().

Those lines used to be special to send the HANGUP with the MSG_OOB flag.  ASTERISK-16242 changed those lines to send normally by simply removing the MSG_OOB flag.

By: Richard Mudgett (rmudgett) 2011-11-07 18:31:15.895-0600

Please test the patch to see if the FastAGI scripts still work.  The only real difference is the HANGUP should show up in the debug output now.


By: Richard Mudgett (rmudgett) 2011-11-15 14:06:32.024-0600

I found confirmation in the code that agi->fd and agi->ctrl are always the same for FastAGI.