|Summary:||ASTERISK-18446: chan_sip rtcachefriends=no loads fullcontact, but doesn't store it, except in astdb|
|Reporter:||Walter Doekes (wdoekes)||Labels:|
|Date Opened:||2011-09-07 06:58:07||Date Closed:||2011-10-12 15:20:25|
|Versions:||10 188.8.131.52 184.108.40.206||Frequency of|
|Description:||See this thread:|
when using uncached realtime peers (i.e. rtcachefriends=no), fullcontact is stored in astdb instead of in the sipregs table.
I have two problems with that:
(1) uncached realtime peers shouldn't be in the astdb (see ASTERISK-17294)
(2) there is no reason to store the fullcontact when the friend is cached and *not* store it in sipregs when it is uncached
Focusing on point (2).
There is this code:
realtime_update_peer(p->name, &p->addr, p->username, rtcachefriends ? p->fullcontact : NULL, p->useragent, expire, p->deprecated_username, p->lastms);
I propose to replace:
rtcachefriends ? p->fullcontact : NULL
For a single UA setup, this will make 0 difference. The fullcontact is stored in the astdb as well and used from there.
For multi-UA setups, the other UAs get access to the fullcontact too, and I can only think of that as an improvement.