Summary:ASTERISK-18390: [patch] New DUNDi cli commands to list cache entries
Reporter:Peter Racz (pracz)Labels:
Date Opened:2011-08-31 04:06:23Date Closed:2012-08-09 09:47:07
Versions:Frequency of
Environment:Attachments:( 0) ASTERISK-18390_dundi_cli_cache_jrose_mods_v2.diff
( 1) dundi_cli_cache.patch
( 2) dundi_cli_cache.patch.v2
Description:This patch adds the following cli commands for DUNDi:
- dundi show cache: List DUNDi cache entries
- dundi show hints: List DUNDi 'DONTASK' hints in the cache
Comments:By: Leif Madsen (lmadsen) 2011-09-14 13:58:28.849-0500

Patching and testing now!

By: Leif Madsen (lmadsen) 2011-09-14 14:21:22.099-0500

Works great so far!

By: Leif Madsen (lmadsen) 2011-09-14 14:27:03.078-0500

I also posted a review for this code at https://reviewboard.asterisk.org/r/1438/ as I tested and it works, and I'd find this useful.

By: Leif Madsen (lmadsen) 2011-09-15 08:08:30.897-0500

If you check reviewboard, there is a review with some changes that would be great if you could get to it. Thanks!

By: Peter Racz (pracz) 2011-09-21 07:01:53.394-0500

New version is attached:
- Added braces { } to if (in case of all cli commands as well)
- Changed "while (...)"
- The "continue" structure proposed will not work with the current "while" implementation because "db_entry = db_entry->next" would not be called. This would result in an endless loop. I think, "continue" would not improve readability either.
- Refactoring the string manipulation
- Fixed a possible bug

By: Leif Madsen (lmadsen) 2011-09-22 08:03:26.533-0500

OK I updated the reviewboard page as well. I'm not sure if I can assign it back to you or not... I couldn't figure it out.

Are you able to place comments etc... on reviewboard as well? Thanks!

By: Peter Racz (pracz) 2011-09-22 09:38:50.714-0500

No, I'm not able to log in to the reviewboard and it is also not clear what I should do there. I don't get the point with "Seems the patch is missing the previous comment in the last review" and the current review is commenting on parts that I didn't change. Could you please tell me what I shall do now?

By: Peter Racz (pracz) 2011-10-07 03:00:58.548-0500

Dear Leif, could you tell me what the status of this patch is and if I'm supposed to do something? Thanks.

By: Leif Madsen (lmadsen) 2011-11-02 13:41:16.120-0500

At this point all you can do is update the review with the latest patch, and make sure everything in the review has been fixed. Beyond that, it will just take someone to give it a Ship It on reviewboard so that someone can take it to commit. If you're interested in getting more exposure on this issue and moving it to resolution, I suggest using the asterisk-dev mailing list.


By: Jonathan Rose (jrose) 2012-07-26 13:07:46.532-0500

Hey Peter, I don't know if you are still wanting to do anything with this project, but I took the liberty of changing some of your code to improve style, fix whitespace, and reduce indentation. The new version is currently on reviewboard. If you would still like to see this patch get into Asterisk, I could either resume working on it with you or you could allow me to take over the patch.

By: Peter Racz (pracz) 2012-08-06 06:36:35.179-0500

Hi Jonathan, thank you for taking some actions for this patch. I'd still like to see this patch get into Asterisk and I appreciate your work. I can work on it with your help. But I'm also happy if you take over the patch since I don't have a reviewboard account and I'm not familiar with the process to get a patch accepted.

By: Jonathan Rose (jrose) 2012-08-09 09:34:46.691-0500

Thanks Peter, I'm currently committing it to trunk as we speak and it will most likely be in the Asterisk 11 beta.