Summary:ASTERISK-18291: Sequence number roll over in res_rtp_multicast.c
Reporter:Will Schick (schicwp)Labels:
Date Opened:2011-08-18 12:49:41Date Closed:2011-10-28 11:39:01
Versions:SVN Frequency of
Environment:AllAttachments:( 0) res_rtp_multicast_seqnowrap.patch
Description:In the write function of the multicast rtp engine, "Definition at line 206 of file res_rtp_multicast.c", the sequence number is stored in a 32 bit u-int, and is incremented without a modulus or roll over check. It is then or-ed into the rtp packet header, so that when it gets larger than 16-bits, it rolls into the codec field. Was having trouble explaining why the codec was changing randomly:).
Comments:By: Jonathan Rose (jrose) 2011-10-20 14:37:39.053-0500

I'm attaching a patch for this issue.  Give it a shot and tell me if it fixes this problem for you.

By: Jonathan Rose (jrose) 2011-10-20 14:38:15.632-0500

Requesting Testing and Feedback from reporter.

By: Alec Davis (alecdavis) 2011-10-28 00:32:26.772-0500

fixed from reviewboard

By: Jonathan Rose (jrose) 2011-10-28 11:39:01.074-0500

Already closed.