|Summary:||ASTERISK-18144: PickupChan not working correctly|
|Reporter:||Erik Smith (eeman)||Labels:|
|Date Opened:||2011-07-16 18:22:25||Date Closed:||2011-07-21 12:35:07|
|Environment:||Centos 5.6, Asterisk 220.127.116.11||Attachments:||( 0) pickupchan_ducumentation-v2.patch|
|Description:||Documentation for PickupChan indicates that the channels are to be comma separated. However when comma separating only the first channel is attempted..|
it appears your code is still trying to use the & as the channel separator
while (!ast_strlen_zero(args.channel) && (pickup = strsep(&args.channel, "&")))
|Comments:||By: Erik Smith (eeman) 2011-07-16 19:03:11.007-0500|
I am unsure of your original intention is to use commas as a field separator since comma is already used as the field separator for the program arguments. I found the following patch to very simply modify the syntax when running 'core show application pickupchan'.. attaching 1 line patch that makes the issue usable.
By: Erik Smith (eeman) 2011-07-16 19:04:21.949-0500
as you can see this is a very simple parameter to your xml for documentation that fixes the command syntax in your helper module.
By: Erik Smith (eeman) 2011-07-16 20:22:39.122-0500
Ok this is a much better patch.. the previous incorrectly used an ampersand to separate the options field. I also changed "channel" to Technology/Resource which is a syntax familiar to everyone as its used in the Dial syntax description.
By: Vadim Mikhnevych (vmikhnevych) 2011-07-21 09:34:55.987-0500
Seems related to this one:
By: Erik Smith (eeman) 2011-07-21 10:40:51.828-0500
it seems so, yet that ticket was marked fixed in march, and here we are in July running a much later version and documentation is still wrong. I just realized you claimed 1.8.4-rc2 didnt have the bug yet the documentation was wrong all the way back to 1.8.0.. was that an err?
By: Richard Mudgett (rmudgett) 2011-07-21 12:34:19.417-0500
That ASTERISK-17494 was only committed to v1.6.2 and BLOCKED in v1.8.
By: Richard Mudgett (rmudgett) 2011-07-21 12:35:07.121-0500
Committed to -r329201 trunk.
Merged revisions 329200 via svnmerge from
r329200 | rmudgett | 2011-07-21 12:32:02 -0500 (Thu, 21 Jul 2011) | 24 lines
Merged revisions 329199 via svnmerge from
r329199 | rmudgett | 2011-07-21 12:30:57 -0500 (Thu, 21 Jul 2011) | 17 lines
Update PickupChan documentation.
The PickupChan uses the ampersand as the argument separator.
Was documented as:
Fixed documentation to:
This is a continuation of ASTERISK-17494 for v1.8 and later.
(closes issue ASTERISK-18144)
Reported by: Erik Smith
pickupchan_ducumentation-v2.patch (License #6263) patch uploaded by Erik Smith
Tested by: Erik Smith