Summary: | ASTERISK-18002: Voicemail MWI no longer is sent | ||||||
Reporter: | Leif Madsen (lmadsen) | Labels: | |||||
Date Opened: | 2011-06-13 11:58:00 | Date Closed: | 2011-06-15 11:59:53 | ||||
Priority: | Blocker | Regression? | |||||
Status: | Closed/Complete | Components: | |||||
Versions: | Frequency of Occurrence | Constant | |||||
Related Issues: |
| ||||||
Environment: | Attachments: | ( 0) jira_asterisk_18002_v1.8_unit_test.patch ( 1) jira_asterisk_18002_v1.8.patch | |||||
Description: | When leaving a voicemail, the MWI message is never sent. The same thing happens when checking a voicemail and marking it as read. If you restart Asterisk, everything comes up at that state correctly, but changes to the messages in voicemail causes the light to not be set appropriately. Very easy to reproduce. | ||||||
Comments: | By: Leif Madsen (lmadsen) 2011-06-14 07:20:15.681-0500 I can confirm that at least this revision works: SVN-trunk-r321814 This is the revision just prior to this commit: r321872 | rmudgett | 2011-06-03 17:02:32 -0400 (Fri, 03 Jun 2011) | 34 lines Event subscription fixes. I will try and move forward here shortly to see if that is in fact that commit that breaks the MWI. By: Leif Madsen (lmadsen) 2011-06-14 07:23:21.842-0500 I have confirmed that 321872 breaks voicemail MWI :) By: Richard Mudgett (rmudgett) 2011-06-14 20:19:03.317-0500 [^jira_asterisk_18002_v1.8.patch] fixes the issue. [^jira_asterisk_18002_v1.8_unit_test.patch] adds a unit test to catch the problem. By: Gregory Hinton Nietsky (irroot) 2011-06-15 00:23:33.774-0500 Applied jira_asterisk_18002_v1.8.patch similar to work in progress patch i put up last night still resolved. Thanks. By: Gregory Hinton Nietsky (irroot) 2011-06-15 00:52:41.249-0500 Can confirm working on Polycom as well used a 601. The report of it been 1.6.2 is highly improbable. 1.8/Trunk are affected in 1.6.2 in match_ie_val_to_sub it returns a 1 not 0 so not affected. By: Gregory Hinton Nietsky (irroot) 2011-06-15 02:33:17.947-0500 Please look at the following for changes to chan_sip.c related to MWI https://issues.asterisk.org/jira/browse/ASTERISK-17866 @leifmadsen when a phone boots up/re registers [SIP] its MWI light is in correct state and the lastmsgssent value is correct this is a regression and the old "expected" behavior. a nice side effect of this patch is that a sip prune / load from the cli will push MWI By: Leif Madsen (lmadsen) 2011-06-15 07:23:47.313-0500 Tested and works over here on my Polycom 335! By: Richard Mudgett (rmudgett) 2011-06-15 11:56:52.460-0500 Merged revisions 323669-323670 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r323669 | rmudgett | 2011-06-15 11:43:18 -0500 (Wed, 15 Jun 2011) | 21 lines [regression] Voicemail MWI is no longer sent. When leaving a voicemail, the MWI message is never sent. The same thing happens when checking a voicemail and marking it as read. If you restart Asterisk, everything comes up at that state correctly, but changes to the messages in voicemail causes the light to not be set appropriately. Very easy to reproduce. * Made ast_event_check_subscriber() return TRUE if there are ANY subscribers to an event type when there are no restricting ie values passed. This allows an event being queued to be queued. (closes issue ASTERISK-18002) Reported by: lmadsen Tested by: lmadsen, irroot Patches: jira_asterisk_18002_v1.8.patch uploaded by rmudgett (License #5621) (closes issue ASTERISK-18019) ........ r323670 | rmudgett | 2011-06-15 11:43:31 -0500 (Wed, 15 Jun 2011) | 7 lines Add a test to the event unit tests to catch ASTERISK-18002. The new tests check to see if there are ANY subscribers to the event type when ast_event_check_subscriber() is not passed any specific ie values. (issue ASTERISK-18002) ........ |