|Summary:||ASTERISK-17958: [patch] The debian init script is still not LSB compliant, #0018896 should not have been closed|
|Date Opened:||2011-06-03 06:55:06||Date Closed:||2012-01-04 14:26:43.000-0600|
|Environment:||Attachments:||( 0) rc.debian.asterisk|
( 1) rc.debian.asterisk.patch
( 2) rc.debian.asterisk.unified-patch
If asterisk is running and the init script is ran as below:
/etc/init.d/asterisk start; echo $?
The following is returned
Asterisk is already running. /etc/init.d/asterisk will exit now.
This violates the LSB standard for return values it should be 0. See:
I've fixed this by modifying line 72. Changing return 1 to return 0. This is actually a big deal for anybody using this script for HA cluster work. I've successfully clustered asterisk servers with pacemaker/corosync using the fixed script below.
Thanks for Asterisk it rocks :-)
- John Cahill
****** ADDITIONAL INFORMATION ******
<inline code removed by lmadsen>
|Comments:||By: Leif Madsen (lmadsen) 2011-06-03 07:16:55|
Sorry, you need to attach patches as a unified diff as a text file attachment after signing the license agreement. Thanks!
By: johnc (gnuday) 2011-06-04 04:49:55
rc.debian.asterisk.unified-patch is a unified patch created using diff -u. I have signed the licence agreement but "[License PENDING (v3.0)]" is still appearing when I submit a patch. Do you guys need to acknowledge my signing of this? Thanks.
By: Kinsey Moore (kmoore) 2012-01-04 14:26:43.655-0600
Fix committed to 1.8, 10, and trunk in r349529, r349532, and r349535, respectively.