[Home]

Summary:ASTERISK-17911: [patch] Ability to dynamically add filters to an ami session
Reporter:Mark Murawski (kobaz)Labels:
Date Opened:2011-05-23 17:52:42Date Closed:2011-07-05 12:02:55
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/ManagerInterface/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) manager_filter.diff
Description:There is already support for white and black filters for AMI events in manager.conf, but they are defined statically.

It would be really great to be able to log in and add filters on the fly for just the current session.

Patch included.
Comments:By: Ronald Chan (loloski) 2011-05-28 00:00:04

kobaz,

I want to test this, could you please give a little instruction on how can we used this. thank you!

By: Mark Murawski (kobaz) 2011-05-28 11:15:59

Check out the reviewboard link for example usage.

https://reviewboard.asterisk.org/r/1228/

Thanks for testing!

By: Leif Madsen (lmadsen) 2011-05-28 20:19:01

Don't forget to add documentation to the patch! :)

By: Leif Madsen (lmadsen) 2011-05-28 20:20:01

And after looking at the patch, half of it IS documentation :)  If there is anything on reviewboard not included in the patch (in terms of how to use it) it'd be great if it was included somewhere in Asterisk as well (or at least something on wiki.asterisk.org). Thanks!

By: Mark Murawski (kobaz) 2011-05-28 20:20:35

I have the command help in the xml. What else would you like me to add?

By: Mark Murawski (kobaz) 2011-05-28 20:21:17

Okay, sounds good.  Do I get wiki edit access?

By: Mark Murawski (kobaz) 2011-07-05 10:53:39.310-0500

updates per reviewboard

By: Mark Murawski (kobaz) 2011-07-05 12:00:18.035-0500

r326267 | markm | 2011-07-05 12:46:17 -0400 (Tue, 05 Jul 2011) | 9 lines

 New feature: AMI Action FilterAdd

 This adds a new action, FilterAdd to the manager interface that allows control over event filters for the current session

 (closes issue ASTERISK-16795)
 Reported by: kobaz
 Tested by: kobaz,loloski