| Summary: | ASTERISK-17879: FastAGI looping when an error happens on fgets | ||
| Reporter: | Nicolas Chapleau (nicchap) | Labels: | |
| Date Opened: | 2011-05-18 09:05:08 | Date Closed: | 2011-06-07 14:05:26 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Resources/res_agi |
| Versions: | 1.8.4 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Issue 0010553 patched things up when an EAGAIN or EINTR error was received during the fgets loop. However, when we DO receive one of these errors, the len variable should NOT be decremented unless we get a valid read res AND no errno. Otherwise, this permits incomplete AGI requests to filter through out of the While loop. ****** ADDITIONAL INFORMATION ****** Simple one liner fix: Adding => if (res && ! errno) (see patch) | ||
| Comments: | By: Nicolas Chapleau (nicchap) 2011-05-18 09:17:30 Actually this was just fixed in issue 16032. Please close. | ||