Summary:	ASTERISK-17787: SIP registration fails in parsing
Reporter:	Olle Johansson (oej)	Labels:	chan-sip-register-parsing
Date Opened:	2011-05-03 07:34:21	Date Closed:
Priority:	Minor	Regression?	No
Status:	Open/New	Components:	Channels/chan_sip/Registration
Versions:	1.8.4 13.18.4	Frequency of Occurrence
Related Issues:	is related to ASTERISK-21295 Sip registration fails, wrong parsing when secret has parentheses symbol is related to ASTERISK-26315 chan_sip does not produce outbound registration - Negative time interval is related to ASTERISK-25843 chan_sip: Registration passwords can not contain @
Environment:		Attachments:
Description:	From sip.conf: register=snow_white:Ros/ling02-@myownserver/5000 gets this error message [May  3 14:29:56] WARNING[96812]: sip/config_parser.c:128 sip_parse_register_line: Format for registration is [peer?][transport://]user[@domain][:secret[:authuser]]@host[:port][/extension][~expiry] at line 165 And nothing is registred. This line works in 1.4 and I don't see why it should not work in 1.8 according to the warning syntax.
Comments:	By: Walter Doekes (wdoekes) 2011-05-03 07:36:32 Because it trips on the / ? Try: register=snow_white:Ros%2Fling02-@myownserver/5000 By: Olle Johansson (oej) 2011-05-03 07:38:13 We never had URI-encoding in the configuration before. Somone rewrote the parser in a bad way while they added a lot of stupid options to the register string... By: Paul Belanger (pabelanger) 2011-05-03 10:20:41 We should add this to the sip_parse_register_line_test AST_TEST. By: Sean Bright (seanbright) 2011-05-03 12:30:50 Does encoding the slash in the password resolve the warning and make the registration work? By: Olle Johansson (oej) 2011-05-04 01:27:40 The password as well as the username can be composed of many characters. This one actually works in 1.4, so it's a regression. Pabelanger: good suggestion! We should test a lot of different strings here. By: Olle Johansson (oej) 2011-05-04 01:31:51 LIke: register=olle@[2001:12:12::1]:password@domain/5000 It's not likely gonna happen that people use the IPv6 URI like that, for authentication. But it is not invalid.