[Home]

Summary:ASTERISK-17786: Fullybooted event is always sent after login
Reporter:Olle Johansson (oej)Labels:
Date Opened:2011-05-03 07:27:12Date Closed:2011-05-03 11:29:11
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/ManagerInterface
Versions:1.8.4 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Everytime I login to manager with "Action:login" I get a fullybooted event, even if the system has been up and running for a long time.
Comments:By: Kiril Valchev (djimbo) 2011-05-03 08:09:24

If you don't want the event, create an event filter for your manager user:
eventfilter=!Event: FullyBooted
By: Michael L. Young (elguero) 2011-05-03 08:14:55

There is a patch on issue ASTERISK-17664 that might help.
By: Olle Johansson (oej) 2011-05-03 08:18:42

The event should not be sent at every login, right? Why fix a bug with a filter?
By: Olle Johansson (oej) 2011-05-03 09:47:56

According to the code review, this is actually how it's supposed to work. I think it would be better if the fullybooted event was added to the login response in that case. This feels rather stupid.

https://reviewboard.asterisk.org/r/639/
By: Olle Johansson (oej) 2011-05-03 09:48:37

This behaviour, that I think is wrong, was the intention of the developer... Life.
By: Terry Wilson (twilson) 2011-05-03 11:29:11

You can't just add it to the login event because there are two cases.

1) You log in before everything is fully booted. You then need a separate event to fire when things are "fully booted".

2) You log in after things are fully booted, but still need to know whether things are fully booted. While you could add something to the login response (Fullybooted: yes/no), in the case of "no" you would still have to wait for the event.

In my opinion, It is easier to write manager apps that just wait for the FullyBooted event before doing anything than to login, parse the login response for fullybooted, then wait for the event in the case that fullybooted is no. Others may disagree. It is a bit more chatty sending the full event every time there is a login. I like the simplicity of onLogin -> WaitForFulllyBooted. There is certainly room for opinion, but this is not a right/wrong issue. Certainly it is not a behavior that will change in 1.8.