[Home]

Summary:ASTERISK-17622: [patch] [regression] H264 video broken due to MARK bit set for each RTP outgoing packet
Reporter:Martin Vit (festr)Labels:
Date Opened:2011-03-30 06:37:14Date Closed:2011-04-18 11:32:49
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:Core/RTP
Versions:1.8.4 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch
Description:H264 video is broken because asterisk set MARK bit for every RTP packet and video stream using more RTP packets for one frame (which is ended with MARK packet) is broken.

I'm attaching patch which will check for mark bit. This check is in asterisk-1.8, it is missing in asterisk-trunk.
Comments:By: Leif Madsen (lmadsen) 2011-04-05 15:27:54

Does this affect the read or writing of H264 video? (or both?) -- just curious as I haven't been able to get video working for a while now, but perhaps that is because of this issue.
By: Martin Vit (festr) 2011-04-05 16:30:58

only writing
By: Martin Vit (festr) 2011-04-15 02:29:19

This has been already commited today in SVN probably independent on founding this bug. You can close it.
By: Richard Mudgett (rmudgett) 2011-04-18 11:32:48

Author: twilson
Date: Thu Apr 14 16:53:01 2011
New Revision: 313822

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=313822
Log:
Sets video mark bit on format field correctly

This fixes a regression in the media architecture change
where video frames did not have their video mark set
correctly.  dvossel wrote this. twilson kindly committed
this, mmichelson found the bug.

Modified:
   trunk/res/res_rtp_asterisk.c