[Home]

Summary:ASTERISK-17566: Unitialized single_binding_found
Reporter:Leif Neland (lenne_dk)Labels:
Date Opened:2011-03-16 13:28:28Date Closed:2011-04-05 15:26:32
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Registration
Versions:1.8.3 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:In line 12978, single_binding_found is defined, but not initialized.


****** ADDITIONAL INFORMATION ******

In function static enum parse_register_result parse_register_contact(..

single_binding_found is used in test
if (wildcard_found && (ast_strlen_zero(expires) || expire != 0 || single_binding_found)) {
                       /* Contact header parameter "*" detected, so punt if: Expires header is missing,
                        * Expires value is not zero, or another Contact header is present. */
                       return PARSE_REGISTER_FAILED;



It might be the reason for the message "chan_sip.c:13843 in register_verify: Failed to parse contact info" suddenly appearing after upgrading to 1.8.3

Initializing single_binding_found to zero made the message disappear.

BTW, I can't select 1.8.3 at the field below here, just 1.8.2.4
Comments:By: Michal (robots) 2011-03-19 19:10:05

This issue is also valid for 1.6.2.17 version and is definitely the reason for the
"register_verify" error.


Patch that fixes this BUG can be found here:
http://robot.mysteria.cz/0001-Fix-variable-initialization.patch

I am sorry for not using the bug tracker's upload system.

By: Sergey Dremlyuzhenko (sergeykrd) 2011-03-30 06:28:24

Seems it is duplicate of 0018785

By: Leif Madsen (lmadsen) 2011-04-05 15:26:32

Closing this in favor of ASTERISK-17382 -- please test the patch there and report back at that issue. Thanks!