[Home]

Summary:ASTERISK-17454: [patch] support gmime-2.4
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2011-02-21 14:13:58.000-0600Date Closed:2011-05-16 09:38:18
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Resources/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) gmime-2.4.diff
( 1) gmime-2.4-18.diff
Description:Debian now migrates to gmime-2.4 . The attached patch fixes the configure script properly but fixes res/res_http_post.c in a way that breaks older versions. This should probably be improved later.
Comments:By: Jeff Stedfast (fejj) 2011-03-05 09:28:13.000-0600

The attached patch isn't quite right... GMime 2.4's foreach callback will iterate over subparts as well, so you don't need/want to do that in process_message_callback().

Also, g_mime_part_get_content_object() no longer refs the returned GMimeDataWrapper object, so the above patch might cause memory corruption.

You can find a better patch here:

http://people.gnome.org/~fejj/asterisk-gmime-2-4.patch


By: Tzafrir Cohen (tzafrir) 2011-03-26 06:43:25

A patch to fix building with gmime 2.4

* Support detecting newer gmime versions (up to 2.4) that use pkg-config.

* Allow building res_http_post.c with newer versions.

* Detecting version is done through a specific constant (GMIME_TYPE_CONTENT_TYPE). Can't think of a simpler build-time test.
By: Tzafrir Cohen (tzafrir) 2011-03-26 07:23:36

Patch applies on trunk (ignore the fuzz, that is created by some white-space changes in near-by lines), and builds fine.
By: Leif Madsen (lmadsen) 2011-05-10 13:40:11

Per Paul I'm marking this as a blocker for 1.8.5.
By: Digium Subversion (svnbot) 2011-05-16 09:35:23

Repository: asterisk
Revision: 319085

U   branches/1.8/configure
U   branches/1.8/configure.ac
U   branches/1.8/include/asterisk/autoconfig.h.in
U   branches/1.8/res/res_http_post.c

------------------------------------------------------------------------
r319085 | pabelanger | 2011-05-16 09:35:22 -0500 (Mon, 16 May 2011) | 10 lines

Support gmime-2.4

(closes issue ASTERISK-17454)
Reported by: tzafrir
Patches:
     gmime-2.4-18.diff uploaded by tzafrir (license 46)
     Tested by: tzafrir

Review: https://reviewboard.asterisk.org/r/1213/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=319085
By: Digium Subversion (svnbot) 2011-05-16 09:38:17

Repository: asterisk
Revision: 319086

_U  trunk/
U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in
U   trunk/res/res_http_post.c

------------------------------------------------------------------------
r319086 | pabelanger | 2011-05-16 09:38:17 -0500 (Mon, 16 May 2011) | 17 lines

Merged revisions 319085 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r319085 | pabelanger | 2011-05-16 10:35:21 -0400 (Mon, 16 May 2011) | 10 lines
 
 Support gmime-2.4
 
 (closes issue ASTERISK-17454)
 Reported by: tzafrir
 Patches:
       gmime-2.4-18.diff uploaded by tzafrir (license 46)
       Tested by: tzafrir
 
 Review: https://reviewboard.asterisk.org/r/1213/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=319086