| Summary: | ASTERISK-17452: parking_offset is write-only in features.conf | ||
| Reporter: | David Woolley (davidw) | Labels: | |
| Date Opened: | 2011-02-21 12:39:01.000-0600 | Date Closed: | 2011-08-16 12:37:54 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Features/Parking |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Code reading for another problem, noticed that the module level variable, parking_offset, is never read. ****** ADDITIONAL INFORMATION ****** svn cat http://svn.digium.com/svn/asterisk/trunk/main/features.c | grep 'parking_offset' int parking_offset; parkinglot->parking_offset = parking_space - parkinglot->parking_star t + 1; default_parkinglot->parking_offset = 0; Also true for 1.6.2 branch. | ||
| Comments: | By: Matthew Nicholson (mnicholson) 2011-07-18 14:25:27.399-0500 It also appears that the "findslot" option in features.conf is not actually used for anything in the code. The parking_offset field is related to this option. By: Richard Mudgett (rmudgett) 2011-08-15 12:52:46.051-0500 There are currently a bunch of issues reported against call parking. These issues are listed with a brief description in the patch I have up on reviewboard[1] to resolve them and other parking issues I found. A team branch[2] from the v1.8 branch is also available to checkout until the patch is merged into the v1.8 and newer branches. The Asterisk Development Team would like some testers to check out the patch and to report on this thread your findings. We would like to compile some real world test scenarios for a wiki page to prevent call parking from getting this badly broken in the future. Thank you Richard [1] https://reviewboard.asterisk.org/r/1358/ [2] http://svn.asterisk.org/svn/asterisk/team/rmudgett/parking By: Richard Mudgett (rmudgett) 2011-08-16 12:37:54.591-0500 Fix committed see subversion commits tab. | ||