Summary:ASTERISK-17367: [patch] AGI streamfile turns off moh, doesn't turn it on
Reporter:Olle Johansson (oej)Labels:
Date Opened:2011-02-08 10:03:12.000-0600Date Closed:2012-09-27 12:43:08
Versions:Frequency of
Environment:Attachments:( 0) 18768.diff
Description:The AGI streamfile command turns off music on hold before streaming a file, but it is never turned on again. I consider this a bug.

I have a patch for this, but since this behaviour has existed for a long time - should we add a config variable somewhere to turn this "correct" behaviour on, in order not to mess up existing applications? If so, in which file?


Found the issue in 1.4
Comments:By: Leif Madsen (lmadsen) 2011-02-08 10:57:04.000-0600

Sounds like a discussion that should be brought up on asterisk-dev.

I'd suggest putting the configuration option in musiconhold.conf. Perhaps...

; musiconhold.conf

reset_agi_streamfile=<yes|no>  ; defaults to no

By: Olle Johansson (oej) 2011-02-09 08:51:31.000-0600

Please read asterisk-dev, Leif. I mailed there immediately.

By: Olle Johansson (oej) 2011-02-09 08:51:53.000-0600

I don't see how res_agi can reach any setting in musiconhold...

By: Leif Madsen (lmadsen) 2011-02-10 11:41:22.000-0600

I don't check asterisk-dev each time I triage issues. However your issue was worded in such a way as to encourage discussion here (and so does your mailing list email). The discussion should happen on asterisk-dev and then the conclusion as to how to process should be done here.

By: Olle Johansson (oej) 2011-04-06 04:23:56

I guess no one wanted to discuss this. What do we do?

By: Olle Johansson (oej) 2011-09-29 04:25:09.550-0500

ast_openstream_full stops the musiconhold. And it's not started again.

By: Luke H (luckman212) 2011-09-29 11:14:13.960-0500

I know it's a real long shot, but any chance this is somehow related to ASTERISK-17474 ?

By: Joshua C. Colp (jcolp) 2012-09-27 12:43:08.141-0500

After reading the existing code, the patch, and the discussions that occurred as a result of this I have determined that changing the behavior is not warranted. Stopping music on hold within streamfile is done as a precaution to ensure it can play the file. It is not designed or expected to restore the state of the world to what it was to this degree. This can be accomplished in the AGI by calling set music before playing the file.

If there are situations where this is not possible I am completely willing to discuss them and re-evaluate my decision.