[Home]

Summary:ASTERISK-17175: [patch] IAX Incorrectly reports IAX/Registry astdb host:port invalid
Reporter:John Covert (jcovert)Labels:
Date Opened:2010-12-28 15:15:50.000-0600Date Closed:2011-02-01 16:48:57.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_iax2
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_iax2.c.patch
Description:When the IAX2 channel reviews the registration database, messages such as the following are reported:

[Dec 28 15:36:32] NOTICE[15998]: chan_iax2.c:8618 reg_source_db: IAX/Registry astdb host:port invalid - '192.168.0.17:4569

However, this is perfectly valid.  This is caused by an incorrect test:

      if (ast_sockaddr_parse(&p->addr, data, PARSE_PORT_REQUIRE)) {
              ast_log(LOG_NOTICE, "IAX/Registry astdb host:port invalid - '%s'\n", data);
              return;
      }

As documented in netsock2.h:

* \retval 0 Failure
* \retval non-zero The number of elements in addrs array.

(which is only partially true: if there were more then 1 elements in the array, a warning would be printed and retval would be forced to 1)

In any case, the sense of the test needs to be reversed.  A patch is attached.
Comments:By: Digium Subversion (svnbot) 2011-02-01 16:48:17.000-0600

Repository: asterisk
Revision: 305692

U   branches/1.8/channels/chan_iax2.c

------------------------------------------------------------------------
r305692 | qwell | 2011-02-01 16:48:16 -0600 (Tue, 01 Feb 2011) | 7 lines

Reverse sense of an error test when reading from astdb.

(closes issue ASTERISK-17175)
Reported by: jcovert
Patches:
     chan_iax2.c.patch uploaded by jcovert (license 551)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=305692
By: Digium Subversion (svnbot) 2011-02-01 16:48:56.000-0600

Repository: asterisk
Revision: 305693

_U  trunk/
U   trunk/channels/chan_iax2.c

------------------------------------------------------------------------
r305693 | qwell | 2011-02-01 16:48:56 -0600 (Tue, 01 Feb 2011) | 14 lines

Merged revisions 305692 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r305692 | qwell | 2011-02-01 16:48:16 -0600 (Tue, 01 Feb 2011) | 7 lines
 
 Reverse sense of an error test when reading from astdb.
 
 (closes issue ASTERISK-17175)
 Reported by: jcovert
 Patches:
       chan_iax2.c.patch uploaded by jcovert (license 551)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=305693