Summary:ASTERISK-17133: [patch] minivm: when sending mail and using volgain
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2010-12-20 05:49:51.000-0600Date Closed:2012-09-06 21:15:07
Versions:SVN 10.1.0 Frequency of
is related toASTERISK-20858 app_minivm fails to clean up mkstemp files
Environment:Attachments:( 0) minivm_18501_demo.diff
Description:There's some questionable code in apps/app_minivm.c:sendmail() at around line 1270 looks odd:

1. tmpfd is opened, but never closed.
2. finalfilename is points to part of the stack that gets de-allocated soon.

Not sure if it causes a crash, as I ran into a different crash issue on the same area. A demo patch is attached anyway.
Comments:By: Matt Jordan (mjordan) 2012-02-02 08:55:31.257-0600

Thank-you for your bug report.  As the module this issue is reported against is in extended support [1], development for it primarily comes from the Asterisk developer community.  As this module may or may not have an active deveoper, your issue may have a lower level of support as compared to the core modules in Asterisk, and response times may reflect that.


By: Tzafrir Cohen (tzafrir) 2012-02-02 09:50:16.382-0600

(1) applies to newer versions as well, but there's a "bug" comment in the code about it, so I figure you don't need my report for it.

(2) still applies as well to current trunk (r353725) - finalfilename points to part of the stack that is already claimed back (right?). The fix in the patch should apply (allocate newtmp in the function's stack), I guess.