ASTERISK-16960: [patch] Core dumped after bridged call is hungup when mysql cdr backend is not available

[Home]

Summary: ASTERISK-16960: [patch] Core dumped after bridged call is hungup when mysql cdr backend is not available

Reporter: Stefan Schmidt (schmidts) Labels:

Date Opened: 2010-11-15 08:27:56.000-0600 Date Closed: 2011-06-08 10:04:01

Priority: Minor Regression? No

Status: Closed/Complete Components: Addons/cdr_mysql

Versions: Frequency of
Occurrence

Related
Issues:

Environment: Attachments: ( 0) issue18309.patch

Description: This only happens with cdr_mysql configured but not reachable (db is gone).
In Row 3578 in main/features.c the if cause a core dump. when i change the order of checks (new_chan_cdr && new_peer_cdr in front before the test flags) this dump doesnt occurs.

the attached patch solves the issue for me but i am not sure if this really solves the problem.

i have found a strange part of code at main/features.c row: 3576 which looks like its in there since rev 166665.
i know this is proper type of c code to keep the livetime of vars short. But this part of code is at the end of the function and its allways called so this extra { } is useless. For better reading we should remove this { }.

Comments: By: Stefan Schmidt (schmidts) 2011-06-08 10:04:01.604-0500

i wasnt able to reproduce this.