Summary:ASTERISK-16944: [patch] Removed resequencing of mailbox
Reporter:Tim King (timking)Labels:
Date Opened:2010-11-11 06:54:40.000-0600Date Closed:2011-04-02 05:06:34
Versions:Frequency of
Environment:Attachments:( 0) 20101118__issue18292.diff.txt
Description:At some point the re-sequencing of filesystem stored voicemails in open_mailbox has been removed (it's still in 1.4). This isn't helpful to all of us who have written web-based systems to access and delete users' voicemails and relied on Asterisk to re-sequence when the web user deleted one or more messages.

It's hard to do outside of Asterisk because of all the locking issues.

Or is there another way that you propose to support this functionality?


Incidentally the latest change in SVN 1.6.2 includes lots of comments about fixes to resequence_mailbox that don't make sense because of its removal.
Comments:By: Leif Madsen (lmadsen) 2010-11-18 15:37:33.000-0600

<Corydon76-dig> It shouldn't be removed, at all
<Corydon76-dig> It's possible that it got refactored and the guy is just missing the code.

By: Tilghman Lesher (tilghman) 2010-11-18 17:29:06.000-0600

jaroth: Since the patch that removed this code originated with you, could you confirm whether this code was removed by accident, or if not, could you illuminate why it was necessary to remove this code?

By: Tilghman Lesher (tilghman) 2010-11-18 17:37:30.000-0600

timking:  it is actually easy to do the resequencing external to Asterisk, because the locking issues have been solved in a portable way, compatible with Asterisk's own locking.  You only need to create a dotfile in the same directory you wish to lock (randomly named), hard link it to ".lock", then check to see if the hard link succeeded or not.  Once you're done with the lock, simply remove the ".lock" file and your original dotfile.

You should at least ATTEMPT to do the resequencing yourself.

By: Alec Davis (alecdavis) 2011-04-02 05:06:34

fixed in http://svnview.digium.com/svn/asterisk?view=revision&revision=303677