| Summary: | ASTERISK-16725: [patch] Crash in check_sounds | ||
| Reporter: | Steve Murphy (murf) | Labels: | |
| Date Opened: | 2010-09-23 23:37:36 | Date Closed: | 2010-10-18 14:17:51 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Sounds |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) check_sounds.c.patch | |
| Description: | When I demo'd this for an interested party, it crashed! So I took some time and debugged it. Simply, I got confused on which variable to use as the file count. I was using numents, but should have been using 'ind'. So I fixed it, and added an extra printf to say how many actual files were in the list (it does tell you how many entries are in the script file.). No more crashes on stock script files issued for 1.4.19 (core). Now, I also added code so it will ignore comment lines that start with a ';' in the first char of the line. I suggest we mod the script files to follow the above format for comments. It will make running the checks easier. ****** STEPS TO REPRODUCE ****** Just run on the 1.4.19 core-sounds-en.txt script file. Apparently, I just tested on the edited version! So I missed this bug. | ||
| Comments: | By: Steve Murphy (murf) 2010-09-28 17:09:49 This bug has been marked "Ready for Testing", and I have but this to say: I have tested the changed code on two or three file groups, and it solves the problems as stated. By: Digium Subversion (svnbot) 2010-10-18 14:17:51 Repository: repotools Revision: 744 U sound_tools/scripts/check_sounds.c ------------------------------------------------------------------------ r744 | lmadsen | 2010-10-18 14:17:50 -0500 (Mon, 18 Oct 2010) | 7 lines Don't crash when checking sound files. (closes issue ASTERISK-16725) Reported by: murf Patches: check_sounds.c.patch uploaded by murf (license 722) Tested by: murf ------------------------------------------------------------------------ http://svn.digium.com/view/repotools?view=rev&revision=744 | ||