Summary:ASTERISK-16697: [patch] segfault on voice frame handling
Reporter:under (under)Labels:
Date Opened:2010-09-18 04:59:14Date Closed:2011-12-02 10:28:15.000-0600
Versions:Frequency of
Environment:Attachments:( 0) segfault.diff
Description:Happens when recvfrom() returns error and sets errno != EAGAIN
Comments:By: Leif Madsen (lmadsen) 2010-09-21 12:49:59

Do you have the backtrace to go along with this patch? I think it would be useful for the developers to see what was being fixed.

By: under (under) 2010-12-27 03:28:54.000-0600

Unfortunately, no. I didn't save it that time.
And this doesn't happen after this patch is applied anymore.

By: Alexander Anikin (may213) 2011-12-02 09:35:09.301-0600

Looks like to trouble is not in the channel driver but asterisk core.
I suggest that affected versions are unsupported already and bugs is fixed for
supported versions.

Neither actual channel drivers use same as in attached patch check for frame pointer that come to
channel write function.

So i will close this issue, it can be reopened if there will same issues for actual
asterisk versions.

By: Alexander Anikin (may213) 2011-12-02 09:36:48.373-0600

Support asterisk version aren't affected this issue

By: Alexander Anikin (may213) 2011-12-02 09:46:04.544-0600

Looks like to i can be wrong and issue is in read channel function not write.
Same check for null frame pointer after ast_rtp_instance_read found in
chan_sip but not in both chan_h323/chan_ooh323.

Will fix this.