[Home]

Summary:ASTERISK-16675: [patch] Application SayUnixTime always jumps to extension when digit sent
Reporter:jlpedrosa (jlpedrosa)Labels:
Date Opened:2010-09-14 10:00:20Date Closed:2011-12-09 14:34:16.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch_SayUnixTime_noJump.patch
( 1) patch_SayUnixTime_noJump.txt
Description:Hi all

If SayUnixTime is running on a channel, if that peer sends DMTF tones, always tryes to reach the extension as digit pressed.

I can provide a patch to add an extra (and optional) parameter to  the application (ie dontjump) in order to be able to choose the behaviour.

Let me know what you think.

Jose Luis Pedrosa
Comments:By: Leif Madsen (lmadsen) 2010-09-14 14:39:43

Hmmm... honestly I think I'd rather see this as a flag to the application ('d' for "don't jump").

Personally, I think if it does work this way it was an oversight and I'd rather remove that as the default usage and enable it explicitly with a flag, but that may not be considered backwards compatible.

By: Leif Madsen (lmadsen) 2010-09-14 14:41:29

Actually, it looks like you may have forgotten to add the patch :)

By: jlpedrosa (jlpedrosa) 2010-09-14 15:35:58

Hi

Yes, I'd rather use a flag and be the default behaviour as don't jump, can agree more whith you, also about backwards compatibility.

I created a patch for me, can redo it adding a last variable for options using d so it's also backwards compatible, for now the only option would be this 'd' option.

Just tell me wich 'default' behaviour you want.

By: Leif Madsen (lmadsen) 2010-09-14 15:51:55

We just discussed this and we would prefer the default to be to not jump, and to add a flag to enable that functionality. It should also be described in the CHANGES file, so make the patch against trunk, where we'll put the changes.

I'll leave it to the developers to determine if they want it backported.

Thanks!
Leif.

By: jlpedrosa (jlpedrosa) 2010-09-15 05:06:49

Hi Leif,

Here's the patch made against the trunk, but the files are identical in 1.6 branch from svn so patch can be aplied without warings on both branchs.

Changes made:
1) Now by default SayUnixTime does not jump to extension when digits pressed.
2) New paramater 'options' added as last argument. It's an option list (AST_APP_OPTIONS) whith only one option:
    'j' for jumping to extension pressed.

I just modified the code and the XML in code for console displays. ┬┐Should I modify something else?

By: David Woolley (davidw) 2010-09-15 11:34:41

You need to sign the electronic licence agreement, then re-submit the patch with the "code or documentation" box ticked.

By: jlpedrosa (jlpedrosa) 2010-09-15 11:40:42

I already sing the agreement

By: jlpedrosa (jlpedrosa) 2010-09-21 06:10:17

Should I put it on the review bard?

By: Leif Madsen (lmadsen) 2010-09-30 09:41:56

Sure! Seems like a decent location :)

By: jlpedrosa (jlpedrosa) 2010-09-30 10:03:42

Done, how can i add the review board link to this issue?
https://reviewboard.asterisk.org/r/956/



By: Stefan Schmidt (schmidts) 2010-10-01 13:29:32

link added ;)