Summary:	ASTERISK-16575: [patch] greetingsfolder variable should be greetingfolder
Reporter:	Edwin horton (edhorton)	Labels:
Date Opened:	2010-08-16 11:46:31	Date Closed:	2011-06-07 14:05:22
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail/IMAP
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) __20100816-app_voicemail-greetingsfolder-support.txt
Description:	The variable to choose an IMAP location for the greetings is referred to in voicemail.conf and other documentation as "greetingsfolder".  In app_voicemail.c, this variable is defined as "greetingfolder".  the "s" is omitted.  If greetingsfolder is used, asterisk correctly defaults to INBOX.
Comments:	By: Leif Madsen (lmadsen) 2010-08-16 15:30:40 I talked to Russell about this and thinks the code should support both and the documentation should reflect whatever seems most appropriate. I think the documentation is correct in that it should be "greetingsfolder". Obviously the code does not handle this right now, so I'm going to attach a patch here to try out in a moment. I'm just building it right now to make sure it'll compile ;) By: Leif Madsen (lmadsen) 2010-08-16 15:40:18 Give this patch a shot. I just compiled to make sure it made it that far but I don't have an IMAP server to test against. By: Edwin horton (edhorton) 2010-08-16 16:54:33 I tried it, but I think the first part of the patch should be: + if (!ast_strlen_zero(greetingsfolder)) { + snprintf(spec, len, "%s%s", tmp, greetingsfolder); + } else { I added the "s". With this now both greetingfolder and greetingsfolder both work correctly for message retrieval and playback. I did try recording a new greeting, and it always writes the message to INBOX but removes it from the Greetings folder.  I changed the IMAP server from maildir format to mbox and there was no difference.  Before I thought it worked correcly in mbox format but had seen this operation with maildir format.  I described this in another issue (0017871).  Maybe I was wrong about the mbox format before.  I will dig further. By: Russell Bryant (russell) 2010-08-17 16:13:27 Leif: I would change this so that you localize your changes to the last hunk of your patch.  Check for both options in the configuration file.  If you don't find the first, look for the second.  If you find either the first or the second, write it into the existing variable.  That will make the changes in the 1st and 2nd hunks of the patch unnecessary. By: Digium Subversion (svnbot) 2011-01-19 17:47:24.000-0600 Repository: asterisk Revision: 302833 U   branches/1.6.2/apps/app_voicemail.c ------------------------------------------------------------------------ r302833 | seanbright | 2011-01-19 17:47:23 -0600 (Wed, 19 Jan 2011) | 7 lines Support greetingsfolder as documented in voicemail.conf.sample. (closes issue ASTERISK-16575) Reported by: edhorton Patches:      __20100816-app_voicemail-greetingsfolder-support.txt uploaded by lmadsen (license 10) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=302833 By: Digium Subversion (svnbot) 2011-01-19 17:49:01.000-0600 Repository: asterisk Revision: 302834 _U  branches/1.8/ U   branches/1.8/apps/app_voicemail.c ------------------------------------------------------------------------ r302834 | seanbright | 2011-01-19 17:49:01 -0600 (Wed, 19 Jan 2011) | 14 lines Merged revisions 302833 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........  r302833 | seanbright | 2011-01-19 18:47:22 -0500 (Wed, 19 Jan 2011) | 7 lines    Support greetingsfolder as documented in voicemail.conf.sample.    (closes issue ASTERISK-16575)  Reported by: edhorton  Patches:        __20100816-app_voicemail-greetingsfolder-support.txt uploaded by lmadsen (license 10) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=302834 By: Digium Subversion (svnbot) 2011-01-19 17:49:55.000-0600 Repository: asterisk Revision: 302835 _U  trunk/ U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r302835 | seanbright | 2011-01-19 17:49:55 -0600 (Wed, 19 Jan 2011) | 21 lines Merged revisions 302834 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r302834 | seanbright | 2011-01-19 18:49:00 -0500 (Wed, 19 Jan 2011) | 14 lines    Merged revisions 302833 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ........    r302833 | seanbright | 2011-01-19 18:47:22 -0500 (Wed, 19 Jan 2011) | 7 lines        Support greetingsfolder as documented in voicemail.conf.sample.        (closes issue ASTERISK-16575)    Reported by: edhorton    Patches:          __20100816-app_voicemail-greetingsfolder-support.txt uploaded by lmadsen (license 10)  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=302835 By: Edwin horton (edhorton) 2011-04-13 15:07:16 Seems to be broken again in 1.6.2.16.2 and 1.8.3.2  greetingfolder is recognized but not greetingsfolder.  Not a big issue, bit seems like the patch below was not included. By: Sean Bright (seanbright) 2011-04-14 09:35:54 It's not broken, those releases were tagged before the patch was committed.  The newer tags (1.6.2.18-rc1 and 1.8.4-rc2) have the fix.