Summary:ASTERISK-16496: [patch] Events are visible after they were removed from EWS calendar
Reporter:Bc. Jan Kaláb (pitel)Labels:
Date Opened:2010-08-03 07:59:02Date Closed:2010-09-17 03:46:47
Versions:Frequency of
Environment:Attachments:( 0) merge_empty_calendar.patch
Description:When suddenly removing last event(s) from calendar, so it become empty, it is still visible in calendar.
Comments:By: Bc. Jan Kaláb (pitel) 2010-08-03 08:02:00

There in information in XML about number of event acquired events. And if it's 0 (<1), we ends the parsing. Bud we didn't merged the empty events list. The patch fixes this issue.

By: Leif Madsen (lmadsen) 2010-08-05 15:12:22

Getting additional testers from the mailing list would be ideal here as well. Thanks for the patch and for testing!

By: Bc. Jan Kaláb (pitel) 2010-08-05 15:35:25

If it's enough, we are already using this patch in company where I work and it fixes the issue for us.

By: Leif Madsen (lmadsen) 2010-08-06 13:39:09

This may be a good issue to review and possibly commit.

By: Leif Madsen (lmadsen) 2010-08-06 13:39:34

Terry -- any chance you can give this a thumbs up or thumbs down?

By: Terry Wilson (twilson) 2010-08-27 08:47:45

thumbs up

By: Digium Subversion (svnbot) 2010-09-17 03:44:29

Repository: asterisk
Revision: 287271

U   branches/1.8/res/res_calendar_ews.c

r287271 | pitel | 2010-09-17 03:44:29 -0500 (Fri, 17 Sep 2010) | 6 lines

Events are visible after they were removed from EWS calendar

Because we must merge calendar even when it's empty.

(closes issue ASTERISK-16496)



By: Digium Subversion (svnbot) 2010-09-17 03:46:47

Repository: asterisk
Revision: 287272

_U  trunk/
U   trunk/res/res_calendar_caldav.c
U   trunk/res/res_calendar_ews.c
U   trunk/res/res_calendar_exchange.c
U   trunk/res/res_calendar_icalendar.c

r287272 | pitel | 2010-09-17 03:46:45 -0500 (Fri, 17 Sep 2010) | 31 lines

Merged revisions 287269-287271 via svnmerge from

 r287269 | pitel | 2010-09-17 10:37:49 +0200 (P?\195?\161, 17 z?\195?\161?\197?\153 2010) | 8 lines
 Support for HTTP redirects in calendar's URL
 libneon does not support HTTP redirects (3xx responses) by default. You must tell it to follow them.
 Also, another little unsigned int fix.
 (closes issue ASTERISK-16487)
 Review: https://reviewboard.asterisk.org/r/921/
 r287270 | pitel | 2010-09-17 10:42:37 +0200 (P?\195?\161, 17 z?\195?\161?\197?\153 2010) | 6 lines
 Asterisk crashing because of double free when EWS request fails
 The free is done later in code. I think ast_free() should have built in checks for double free.
 (closes issue ASTERISK-16493)
 r287271 | pitel | 2010-09-17 10:44:28 +0200 (P?\195?\161, 17 z?\195?\161?\197?\153 2010) | 6 lines
 Events are visible after they were removed from EWS calendar
 Because we must merge calendar even when it's empty.
 (closes issue ASTERISK-16496)