Summary:ASTERISK-16489: [patch] add imapserver in voicemail.c
Reporter:Hubert Mickael (mickaelhexanet)Labels:
Date Opened:2010-08-02 13:09:52Date Closed:2011-12-23 15:20:16.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_voicemail.patch.txt
( 1) svndiffpatch_app_voicemail.patch
( 2) svndiffpatch_app_voicemail.patch.txt
I'm sorry I'm not developer, but I added to voicemail.c the possibility to use variable imapserver in a DB mysql
I wanted to be able to modify the imap server for each users.


line 885: open_mailbox(struct vm_state *vms, struct ast_vm_user *vmu, int box) --> add struct ast_vm_user.

line 2445:  ast_build_string(&t, &left, "{%s:%s/imap", vmu->imapserver, imapport); --> add vmu->imapserver.

and in voicemail table in mysql add "imapserver" varchar 30 for the IP.

I note just the thing important because there have been other changes in the declarations of other functions.
This small modification works, but it can possibly cause an other bug. Can you to integrate with the next release?


This information can be interested a real developer, and may create a patch to add this option,
Comments:By: Hubert Mickael (mickaelhexanet) 2010-08-02 13:20:27

I'm sorry, there were other changes, I send you my file, make a vimdiff

By: Paul Belanger (pabelanger) 2010-08-02 19:58:14

Please use

svn diff

on all your patches. Patches which include alternate formatting are almost certainly going to be thrown out or ignored; there are too few hours in the day to wade through difficult-to-follow C code fixes without the help of svn diff.


By: Hubert Mickael (mickaelhexanet) 2010-08-03 10:09:43

ok, no problem, i create a patch file, but I dont can send on this site, there is an error message. please, can you help me ?

By: Leif Madsen (lmadsen) 2010-08-03 13:54:34

There is a box where you Select File, hit the Browse button, select the 'diff' and then check the appropriate box to mark it as code. Then hit the Upload File button.

By: Hubert Mickael (mickaelhexanet) 2010-08-03 15:38:46

ok, it's good, patch file is in line "app_voicemail.patch.txt", It was created by the patch command.

I think the possibility of a different imap server per user is very interesting. but my code is not perfect.

Thank you for your understanding

By: Paul Belanger (pabelanger) 2010-08-18 07:54:54

We still need a patch generated with 'svn diff'.

By: Leif Madsen (lmadsen) 2010-08-31 14:49:29

Pinging this issue prior to closing.

By: Hubert Mickael (mickaelhexanet) 2010-09-10 13:57:32

Hi, it's ok , I upload my patch make with SVN DIF.

can you see, and correct it to include it in the next release


By: Leif Madsen (lmadsen) 2010-09-13 11:00:42

Marking as Ready for Testing prior to review by a developer.

By: Hubert Mickael (mickaelhexanet) 2010-09-13 12:47:37

it's very good, I repeat, I'm not developer, perhaps there was fault in the code.
This function it's very interesting.