[Home]

Summary:ASTERISK-16377: app_amd total analysis time error with SIP and silence suppression on
Reporter:Julian (juls)Labels:
Date Opened:2010-07-15 21:46:25Date Closed:2010-07-16 12:18:01
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_amd
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:When using app_amd with SIP providers that have silence suppression on, the iTotalTime count increases exponentially.

This results in a Too Long.. error message way before the totalAnalysisTime is actually reached.

Example
say the maxWaitTimeForFrame is 50.
then the iTotalTime increases as follows
100, 300, 600, 1000, 1500, 2800

It is reproducible on both 1.4 or 1.6 branches


****** ADDITIONAL INFORMATION ******

offending code is on the fourth line of following (which is roughly 200 lines down from the start of the code)

1.  if (f->frametype == AST_FRAME_VOICE)
2.                                 framelength = (ast_codec_get_samples(f) /  DEFAULT_SAMPLES_PER_MS);
3.                        else
4.                                framelength += 2 * maxWaitTimeForFrame;

probably should be
framelength = 2 * maxWaitTimeForFrame;
Comments:By: Digium Subversion (svnbot) 2010-07-16 12:10:36

Repository: asterisk
Revision: 277182

U   branches/1.4/apps/app_amd.c

------------------------------------------------------------------------
r277182 | pabelanger | 2010-07-16 12:10:35 -0500 (Fri, 16 Jul 2010) | 8 lines

Total analysis time error with SIP and silence suppression

When using app_amd with SIP providers that have silence
suppression on, the iTotalTime count increases exponentially.

(closes issue ASTERISK-16377)
Reported by: juls

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277182
By: Digium Subversion (svnbot) 2010-07-16 12:13:46

Repository: asterisk
Revision: 277183

_U  trunk/
U   trunk/apps/app_amd.c

------------------------------------------------------------------------
r277183 | pabelanger | 2010-07-16 12:13:45 -0500 (Fri, 16 Jul 2010) | 15 lines

Merged revisions 277182 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r277182 | pabelanger | 2010-07-16 13:10:36 -0400 (Fri, 16 Jul 2010) | 8 lines
 
 Total analysis time error with SIP and silence suppression
 
 When using app_amd with SIP providers that have silence
 suppression on, the iTotalTime count increases exponentially.
 
 (closes issue ASTERISK-16377)
 Reported by: juls
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277183
By: Digium Subversion (svnbot) 2010-07-16 12:18:00

Repository: asterisk
Revision: 277188

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_amd.c

------------------------------------------------------------------------
r277188 | pabelanger | 2010-07-16 12:18:00 -0500 (Fri, 16 Jul 2010) | 22 lines

Merged revisions 277183 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r277183 | pabelanger | 2010-07-16 13:13:46 -0400 (Fri, 16 Jul 2010) | 15 lines
 
 Merged revisions 277182 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r277182 | pabelanger | 2010-07-16 13:10:36 -0400 (Fri, 16 Jul 2010) | 8 lines
   
   Total analysis time error with SIP and silence suppression
   
   When using app_amd with SIP providers that have silence
   suppression on, the iTotalTime count increases exponentially.
   
   (closes issue ASTERISK-16377)
   Reported by: juls
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277188