[Home]

Summary:ASTERISK-16345: [patch] convert 6 modules to use <module> show settings
Reporter:Paul Belanger (pabelanger)Labels:patch
Date Opened:2010-07-09 23:12:55Date Closed:
Priority:MajorRegression?No
Status:Open/NewComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue17618.patch
( 1) issue17618.patch.v2
Description:As discussed on the mailing list, a few modules slipped by.
Comments:By: Leif Madsen (lmadsen) 2010-07-12 11:01:32

Following the <module> <verb> <options> formatting, do you think we should actually do:

cdr show mysql settings

?

By: Tilghman Lesher (tilghman) 2010-07-12 11:12:40

Additionally, the MySQL CDR command really is the status of the module, not the settings, so even while we modify it, we should keep "status" in the command predicate.  "cdr show mysql status".

In the aliases file, you have "sql show settings" and it should be "sqlite show settings".



By: Paul Belanger (pabelanger) 2010-07-12 11:27:55

Will make the changes and reupload patch.

By: Leif Madsen (lmadsen) 2010-07-16 13:23:47

If you need more feedback on this put it on reviewboard. Mmmmkthxbye!