Summary:ASTERISK-16329: [patch] Add support for phones with less than 3 LCD lines
Reporter:Mina Naguib (minaguib)Labels:
Date Opened:2010-07-07 12:23:40Date Closed:2010-07-10 09:44:24
Versions:Frequency of
Environment:Attachments:( 0) ast_unistim_height_v2.patch
( 1) ast_unistim_height.patch
Description:I have a few Nortel I2002 and I2001 phones that work, but they only have 1 "line" of display on the LCD.  The existing driver assumes 3, so some info, sometimes pivotal (the number you're dialing, the xfer status, etc) is not viewable.

This patch adds support for a "height" attribute per device, and some code for better handling of 1-height devices.  It's based on the work done by Takao Takahashi mentioned here: http://www.voip-info.org/wiki/view/Asterisk+UNISTIM+channels
Comments:By: Leif Madsen (lmadsen) 2010-07-09 14:30:18

There are probably very few people who can test this, so if someone can do a quick code review and it looks sane, should just commit this.

By: Leif Madsen (lmadsen) 2010-07-09 14:33:40

Sorry, this issue can't be committed because the original author would need to sign off on this.

By: Leif Madsen (lmadsen) 2010-07-09 14:34:52

If the original author were to submit (attach) his original patch here, then we could commit this.

By: Leif Madsen (lmadsen) 2010-07-09 14:35:45

Actually I closed this too quickly -- I'm going to just set this to Feedback so the reporter has the opportunity to try and get the original author to attach his original patch here after signing the license agreement.

By: Mina Naguib (minaguib) 2010-07-09 17:21:07

I will ping the original author (Takao Takahashi) of the original 1-line patch.

By: Takao Takahashi (takaotakahashi) 2010-07-09 20:25:45

I am the author of original patch. Yes, I approve this issue.

By: Mina Naguib (minaguib) 2010-07-09 21:03:16

If it helps (re testing) I'm running around 8 of these phones (a mix of Nortel I2001 and I2002) in a small office on asterisk with this patch for roughly a week, and it's been solid.

Without explicitly setting "height=1" on a device in unistim.conf, the previous behavior is unaltered.

By: Paul Belanger (pabelanger) 2010-07-09 21:20:15

Some minor CODING-GUIDELINES that will need cleaning up:

* Inline CREDITS nolonger belong within patches.  Refer to the CREDITS file.
* braces for if .. else statements. Specifically '} else {'

By: Mina Naguib (minaguib) 2010-07-09 21:33:45

Uploaded ast_unistim_height_v2.patch addressing pabelanger's points reviewing the previous patch.

By: Digium Subversion (svnbot) 2010-07-10 09:44:18

Repository: asterisk
Revision: 275466

U   trunk/CHANGES
U   trunk/CREDITS
U   trunk/channels/chan_unistim.c
U   trunk/configs/unistim.conf.sample

r275466 | russell | 2010-07-10 09:44:18 -0500 (Sat, 10 Jul 2010) | 8 lines

Add support for devices with less than 3 lines on the LCD.

(closes issue ASTERISK-16329)
Reported by: minaguib
     ast_unistim_height_v2.patch uploaded by minaguib (license 1078)
Tested by: minaguib