[Home]

Summary:ASTERISK-16320: [patch] applicationmap groups do not work (either lack of documentation, or feature incomplete)
Reporter:Leif Madsen (lmadsen)Labels:
Date Opened:2010-07-06 07:42:47Date Closed:2010-07-09 17:01:01
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue_17589.rev4.txt
Description:While trying to document the applicationmap groups (which seems like a cool enough feature), I think I've found a few bugs.

In the additional information I have the part of my features.conf that I'm using.

I've defined 3 groups (the top one is the example from the configuration file); lme, coretel, and shifteight

The features exist and do work when dialing them directly. This is after creating the dialplan with:

Set(__DYNAMIC_FEATURES=agi_test)   (for example)

However, if I do something like:

Set(__DYNAMIC_FEATURES=lme)

Then I can't access the feature.


Additionally, the example seems to show that I can simply place features into the group and it will then use the exist digit mapping, but when loading the features module, I get this error:

[Jul  6 04:03:09] WARNING[15874]: config.c:1178 process_text_line: No '=' (equal sign) in line 179 of /etc/asterisk/features.conf


So it seems the features module is expecting me to define a mapping digit (which I don't think should be necessary).

In addition to this, there is no listing of the groups when running 'features show' from the Asterisk CLI. When you 'features reload' you can see that the groups are being loaded into memory, but 'features show' does not describe them.

(When you create the parking lots, it does show them all though, so this appears to be part of the feature that is incomplete)


****** ADDITIONAL INFORMATION ******

; [myGroupName]        ; defines the group named myGroupName
; testfeature => ASTERISK-5    ; associates testfeature with the group and the keycode ASTERISK-5
; pauseMonitor         ; associates pauseMonitor with the group and the keycode

[shifteight]
agi_test

[lme]
agi_test => ASTERISK-5

[coretel]
unpauseMonitor => *1
pauseMonitor => *2
agi_test
Comments:By: Russell Bryant (russell) 2010-07-09 15:07:37

I have uploaded a patch:

1) I updated the documentation to state that an '=' is required when specifying a feature but using the default key mapping.

2) I fixed an error in CLI output that did not show the proper key mapping during configuration parsing, and would show blank in the case where the default from [applicationmap] was being ued.

3) I added the feature groups to the 'feature show' CLI command output.
By: Russell Bryant (russell) 2010-07-09 16:47:28

I have attached the latest patch that lmadsen and I tested successfully.
By: Leif Madsen (lmadsen) 2010-07-09 16:48:02

Tested successfully here!
By: Digium Subversion (svnbot) 2010-07-09 16:57:20

Repository: asterisk
Revision: 275424

U   trunk/configs/features.conf.sample
U   trunk/main/features.c

------------------------------------------------------------------------
r275424 | russell | 2010-07-09 16:57:20 -0500 (Fri, 09 Jul 2010) | 27 lines

Fix some issues related to dynamic feature groups in features.conf.

The bridge handling code did not properly consider feature groups when setting
parameters that would affect whether or not a native bridge would be attempted.
If DYNAMIC_FEATURES only include a feature group, a native bridge would occur
that may prevent features from working.

Fix a bug in verbose output that would show the key mapping as empty if it was
using the default mapping and not a custom mapping in the feature group.

Add feature groups to the output of "features show".

Adjust the feature execution logic to match that of the logic when executing
a feature that was not configured through a feature group.

Update features.conf.sample to show that an '=' is still required if using
the default key mapping from [applicationmap].

Finally, clean up a little bit of formatting to better coform to coding
guidelines while in the area.

(closes issue ASTERISK-16320)
Reported by: lmadsen
Patches:
     issue_17589.rev4.txt uploaded by russell (license 2)
Tested by: russell, lmadsen

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=275424
By: Digium Subversion (svnbot) 2010-07-09 17:01:00

Repository: asterisk
Revision: 275425

_U  branches/1.6.2/
U   branches/1.6.2/configs/features.conf.sample
U   branches/1.6.2/main/features.c

------------------------------------------------------------------------
r275425 | russell | 2010-07-09 17:01:00 -0500 (Fri, 09 Jul 2010) | 34 lines

Merged revisions 275424 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r275424 | russell | 2010-07-09 16:57:21 -0500 (Fri, 09 Jul 2010) | 27 lines
 
 Fix some issues related to dynamic feature groups in features.conf.
 
 The bridge handling code did not properly consider feature groups when setting
 parameters that would affect whether or not a native bridge would be attempted.
 If DYNAMIC_FEATURES only include a feature group, a native bridge would occur
 that may prevent features from working.
 
 Fix a bug in verbose output that would show the key mapping as empty if it was
 using the default mapping and not a custom mapping in the feature group.
 
 Add feature groups to the output of "features show".
 
 Adjust the feature execution logic to match that of the logic when executing
 a feature that was not configured through a feature group.
 
 Update features.conf.sample to show that an '=' is still required if using
 the default key mapping from [applicationmap].
 
 Finally, clean up a little bit of formatting to better coform to coding
 guidelines while in the area.
 
 (closes issue ASTERISK-16320)
 Reported by: lmadsen
 Patches:
       issue_17589.rev4.txt uploaded by russell (license 2)
 Tested by: russell, lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=275425