[Home]

Summary:ASTERISK-16292: [patch] voicemail_odbc_postgresql step 11 typo
Reporter:cmaj (cmaj)Labels:
Date Opened:2010-06-25 12:52:21Date Closed:2010-06-25 15:23:32
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Documentation
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch-bug-17557.txt
Description:Example sanity check query looks for undefined column "id" -- should be "callerid".

Please change this:

[jsmith2@localhost ODBC]$ echo "SELECT id, msgnum, dir, duration FROM voicemessages WHERE msgnum = 1" | isql testing

To this:

[jsmith2@localhost ODBC]$ echo "SELECT callerid, msgnum, dir, duration FROM voicemessages WHERE msgnum = 1" | isql testing

Thank you!

****** ADDITIONAL INFORMATION ******

Exists in 1.6.0.28 as well.
Comments:By: Paul Belanger (pabelanger) 2010-06-25 13:22:20

Patch? I'm not sure what you are referring too.

By: Leif Madsen (lmadsen) 2010-06-25 13:53:50

Why? As far as I understand it this SELECT statement is simply to verify taht you can get data back over the ODBC connection.

By: Tilghman Lesher (tilghman) 2010-06-25 14:06:02

This is actually specific to 1.6.2 and forward.  In previous versions, the "id" column was required, because we did not support multi-column unique indexes.  Starting in 1.6.2, we started supporting that, so the requirement (and specification) of the id column was dropped.

By: cmaj (cmaj) 2010-06-25 15:01:10

Patch attached.

"voicemail" table has no "id" column so SELECT fails on non-existent column.

Problem exists in 1.6.0.28 as well.

By: Tilghman Lesher (tilghman) 2010-06-25 15:08:00

cmaj: only because your database table doesn't have the "id" column.  In the documentation in 1.6.0, we recommend the inclusion of the "id" column in contrib/scripts/realtime_pgsql.sql.  There's a LOT more things that will fail in 1.6.0 if the "id" column is missing.

By: Digium Subversion (svnbot) 2010-06-25 15:17:36

Repository: asterisk
Revision: 272562

U   branches/1.4/doc/voicemail_odbc_postgresql.txt

------------------------------------------------------------------------
r272562 | tilghman | 2010-06-25 15:17:35 -0500 (Fri, 25 Jun 2010) | 5 lines

Make the structure of the table specified before match the queries and results.

(closes issue ASTERISK-16292)
Reported by: cmaj

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=272562

By: Digium Subversion (svnbot) 2010-06-25 15:18:46

Repository: asterisk
Revision: 272568

_U  trunk/
U   trunk/doc/voicemail_odbc_postgresql.txt

------------------------------------------------------------------------
r272568 | tilghman | 2010-06-25 15:18:45 -0500 (Fri, 25 Jun 2010) | 12 lines

Merged revisions 272562 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r272562 | tilghman | 2010-06-25 15:17:37 -0500 (Fri, 25 Jun 2010) | 5 lines
 
 Make the structure of the table specified before match the queries and results.
 
 (closes issue ASTERISK-16292)
  Reported by: cmaj
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=272568

By: Digium Subversion (svnbot) 2010-06-25 15:20:27

Repository: asterisk
Revision: 272577

_U  branches/1.6.2/
U   branches/1.6.2/doc/voicemail_odbc_postgresql.txt

------------------------------------------------------------------------
r272577 | tilghman | 2010-06-25 15:20:26 -0500 (Fri, 25 Jun 2010) | 19 lines

Merged revisions 272568 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r272568 | tilghman | 2010-06-25 15:18:47 -0500 (Fri, 25 Jun 2010) | 12 lines
 
 Merged revisions 272562 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r272562 | tilghman | 2010-06-25 15:17:37 -0500 (Fri, 25 Jun 2010) | 5 lines
   
   Make the structure of the table specified before match the queries and results.
   
   (closes issue ASTERISK-16292)
    Reported by: cmaj
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=272577

By: Tilghman Lesher (tilghman) 2010-06-25 15:23:32

Per the Asterisk maintenance timeline page at http://www.asterisk.org/asterisk-versions maintenance (bug) support for the 1.6.0 and 1.6.1 branches has ended. For continued maintenance support please move to the 1.6.2 branch.

More information on this change can be found in the release announcement: http://www.asterisk.org/node/49924