[Home]

Summary:ASTERISK-16272: [patch] unload mod is not complete
Reporter:Clod Patry (junky)Labels:
Date Opened:2010-06-20 10:25:44Date Closed:2010-07-09 14:36:19
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) unload_vs_mod_unload.diff
Description:In the CLI,
if you type:
*CLI> unload chan_<tab>
chan_agent.so  chan_iax2.so   chan_mgcp.so   chan_sip.so    
*CLI> module unload chan<tab>
chan_agent.so   chan_iax2.so    chan_local.so   chan_mgcp.so    chan_oss.so     chan_phone.so   chan_sip.so     chan_skinny.so  
*CLI> module unload chan_

the unload (which is deprecated in 1.4) should contains the same list as module unload, when you hit Tab.
Not a big deal, since that command disapeared in 1.6.x, but still a small bug in 1.4.

The reason why, it's because the unload is calling the list with the needs_reload, which means, if a module is not possible to reload, it won't be tab-completed.

****** ADDITIONAL INFORMATION ******

I had to create a new function, since the command reload was calling the same tab-completion function.
After the patch:
*CLI> reload chan_ <tab>
chan_agent.so  chan_iax2.so   chan_mgcp.so   chan_sip.so    
*CLI> module reload chan_ <tab>
chan_agent.so  chan_iax2.so   chan_mgcp.so   chan_sip.so    
*CLI> module reload chan_

which are the same list (only the module reloadable are listed)


*CLI> unload chan_
chan_agent.so   chan_iax2.so    chan_local.so   chan_mgcp.so    chan_oss.so     chan_phone.so   chan_sip.so     chan_skinny.so  
*CLI> module unload ch


*CLI> module unload chan_ <tab>
chan_agent.so   chan_iax2.so    chan_local.so   chan_mgcp.so    chan_oss.so     chan_phone.so   chan_sip.so     chan_skinny.so  
*CLI> module unload chan_

Which, again contains the same list.
Comments:By: Paul Belanger (pabelanger) 2010-06-21 13:08:50

download, tested and works as expected.
By: Leif Madsen (lmadsen) 2010-07-09 14:21:50

Someone should just commit this (Claude or Paul)
By: Digium Subversion (svnbot) 2010-07-09 14:36:18

Repository: asterisk
Revision: 275290

U   branches/1.4/main/cli.c

------------------------------------------------------------------------
r275290 | pabelanger | 2010-07-09 14:28:48 -0500 (Fri, 09 Jul 2010) | 8 lines

fix tab-completion for unload command.

(closes issue ASTERISK-16272)
Reported by: junky
Patches:
     unload_vs_mod_unload.diff uploaded by junky (license 177)
Tested by: pabelanger

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=275290