[Home]

Summary:ASTERISK-16271: [patch] queue reload clears queue statistics
Reporter:raarts (raarts)Labels:
Date Opened:2010-06-20 09:09:24Date Closed:2010-09-02 00:31:49
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100819__issue17535.diff.txt
( 1) keepstats.diff
Description:When reloading the queue configuration on the CLI the queue statistics are cleared. Very undesirable. patch attached.
Comments:By: Evandro C├ęsar Arruda (ecarruda) 2010-06-20 09:48:50

raarts,

Beaultiful patch, i writed a patch to manual reset statistics, i will open new issues thread and request to create relationship with yours.

Thanks man

By: Leif Madsen (lmadsen) 2010-06-23 11:01:09

Your patch re-implements the keepstats option which was refused to be put back in via comments by russell in bug ASTERISK-15243 which you opened.

What version of 1.6.2 did the stats reset on upon reload? I suspect this is not a bug but is intentional behaviour.

By: raarts (raarts) 2010-06-23 13:13:12

I think there is a lot of confusion due to the wording of various bug reports and misunderstanding, and I think Russell also misunderstood my intentions.

Instead of re-opening my previous bug report which - I felt - would make me look like a obnoxious pitbull, I decided to create a new bug-report, with a different description, which would hopefully get the message through: the way it works now is wrong. A CLI reload should not clear the queue statistics.  

That's what I want to fix with this patch. I think the keepstats option is silly, but maybe there really are people who *want* reload to clear the queue stats.

By: Leif Madsen (lmadsen) 2010-06-30 12:43:10

I would have rather you reopened the other issue rather than intentionally mislead us.

By: Paul Belanger (pabelanger) 2010-06-30 12:45:23

Closing per russellb original comments.  Ping #asterisk-dev for more information / comments.

By: raarts (raarts) 2010-08-17 03:34:18

Re-opening as russel now said on asterisk-dev that this is indeed a bug and not expected behaviour. See this thread: http://lists.digium.com/pipermail/asterisk-dev/2010-August/045792.html

By: raarts (raarts) 2010-08-17 03:39:47

I think there's one thing left: should I alter my patch to just fix the problem, or does anyone think there are people actually relying on the stats being cleared on reload. In that case the name of the keepstats option should maybe be changed to resetstatsonreload, and have that default to 'no'.

By: Tilghman Lesher (tilghman) 2010-08-19 14:43:15

Actually, there's no need for a "keepstats" option at all -- the behavior should simply be to not clear statistics on a reload AT ALL.

By: Tilghman Lesher (tilghman) 2010-08-19 14:50:35

Just a one line change should be all that is needed.  Please test and verify that this solves the issue.

By: Tilghman Lesher (tilghman) 2010-08-30 14:53:12

Testing?  Bueller?  Bueller?

By: raarts (raarts) 2010-08-31 01:30:19

I don't know what Bueller, Bueller means, but I am too tied up at the moment.
We will start a testrun for the next 2 weeks, so that should give me the chance to add this to the testing list. BTW I think it needs three lines, in the reload(), and in some manager commands.

By: Digium Subversion (svnbot) 2010-09-02 00:30:16

Repository: asterisk
Revision: 284631

U   branches/1.6.2/apps/app_queue.c

------------------------------------------------------------------------
r284631 | tilghman | 2010-09-02 00:30:16 -0500 (Thu, 02 Sep 2010) | 7 lines

Don't reset queue stats on a module reload.

(closes issue ASTERISK-16271)
Reported by: raarts
Patches:
      20100819__issue17535.diff.txt uploaded by tilghman (license 14)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=284631

By: Digium Subversion (svnbot) 2010-09-02 00:31:03

Repository: asterisk
Revision: 284632

_U  branches/1.8/
U   branches/1.8/apps/app_queue.c

------------------------------------------------------------------------
r284632 | tilghman | 2010-09-02 00:31:03 -0500 (Thu, 02 Sep 2010) | 14 lines

Merged revisions 284631 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r284631 | tilghman | 2010-09-02 00:30:16 -0500 (Thu, 02 Sep 2010) | 7 lines
 
 Don't reset queue stats on a module reload.
 
 (closes issue ASTERISK-16271)
  Reported by: raarts
  Patches:
        20100819__issue17535.diff.txt uploaded by tilghman (license 14)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=284632

By: Digium Subversion (svnbot) 2010-09-02 00:31:48

Repository: asterisk
Revision: 284633

_U  trunk/
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r284633 | tilghman | 2010-09-02 00:31:48 -0500 (Thu, 02 Sep 2010) | 21 lines

Merged revisions 284632 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r284632 | tilghman | 2010-09-02 00:31:02 -0500 (Thu, 02 Sep 2010) | 14 lines
 
 Merged revisions 284631 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r284631 | tilghman | 2010-09-02 00:30:16 -0500 (Thu, 02 Sep 2010) | 7 lines
   
   Don't reset queue stats on a module reload.
   
   (closes issue ASTERISK-16271)
    Reported by: raarts
    Patches:
          20100819__issue17535.diff.txt uploaded by tilghman (license 14)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=284633