[Home]

Summary:ASTERISK-16257: [patch] EventList start and EventList end manager variables do not match
Reporter:Mark Murawski (kobaz)Labels:
Date Opened:2010-06-17 10:22:35Date Closed:2010-07-06 15:08:24
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/ManagerInterface
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) manager.patch
Description:In manager.c: astman_send_response_full()... we have


if (listflag) {
 astman_append(s, "Eventlist: %s\r\n", listflag);        /* Start, complete, cancelled */
}

and i chan_sip.c (and other places)... we have:
      astman_append(s,
               "Event: RegistrationsComplete\r\n"
               "EventList: Complete\r\n"
               "ListItems: %d\r\n"
               "%s"
               "\r\n", total, idtext);

If someone is expecting to look at EventList for the 'start' and 'Complete', they'll never see it for 'start' since, it's Eventlist (no upper case L)



****** ADDITIONAL INFORMATION ******

removed inline patch - pabelanger
Comments:By: Ronald Chan (loloski) 2010-06-17 11:20:59

kobaz,

what's the change? can you change again your patch?
By: Ronald Chan (loloski) 2010-06-17 11:21:45

can you check rather * sorry
By: Mark Murawski (kobaz) 2010-06-17 11:31:42

The change is in the patch that was uploaded.
By: Leif Madsen (lmadsen) 2010-06-17 13:28:43

I wonder if this is a trunk only change as someone may have figured that out and worked around it.
By: Leif Madsen (lmadsen) 2010-06-23 15:29:34

Discussed, and this has been deemed to be ready for all branches it affects.
By: Digium Subversion (svnbot) 2010-06-23 15:35:44

Repository: asterisk
Revision: 272252

U   trunk/main/manager.c

------------------------------------------------------------------------
r272252 | pabelanger | 2010-06-23 15:35:44 -0500 (Wed, 23 Jun 2010) | 8 lines

Correct manager variable 'EventList' case.

(closes issue ASTERISK-16257)
Reported by: kobaz
Patches:
     manager.patch uploaded by kobaz (license 834)
Tested by: lmadsen

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=272252
By: Digium Subversion (svnbot) 2010-06-23 15:37:06

Repository: asterisk
Revision: 272253

_U  branches/1.6.2/
U   branches/1.6.2/main/manager.c

------------------------------------------------------------------------
r272253 | pabelanger | 2010-06-23 15:37:06 -0500 (Wed, 23 Jun 2010) | 15 lines

Merged revisions 272252 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r272252 | pabelanger | 2010-06-23 16:35:45 -0400 (Wed, 23 Jun 2010) | 8 lines
 
 Correct manager variable 'EventList' case.
 
 (closes issue ASTERISK-16257)
 Reported by: kobaz
 Patches:
       manager.patch uploaded by kobaz (license 834)
 Tested by: lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=272253