[Home]

Summary:ASTERISK-16254: Norwegian language - wrong word
Reporter:Marius (mariussm)Labels:
Date Opened:2010-06-17 03:44:03Date Closed:2011-06-07 14:05:27
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:When calling voicemailmain(), and having no messages, a wrong word is pronounced.

In english, the phrase says:
"You have no messages", which should translate to "Du har ingen meldinger" in norwegian. What it actually says now is "Du har nei meldinger", which is the direct (but wrong) translation.

"Du har nei meldinger" - "Nei" is the oposit of yes, it's like saying "you have nothing messages".
"Du har ingen meldinger" - Is like saying you don't have any messages

I app_voicemail.c, vm_intro_no() should be changed:
       if (!vms->oldmessages && !vms->newmessages && !vms->urgentmessages) {
               res = ast_play_and_wait(chan, "vm-no");
               res = res ? res : ast_play_and_wait(chan, "vm-messages");
               return res;
       }


To:
       if (!vms->oldmessages && !vms->newmessages && !vms->urgentmessages) {
               res = ast_play_and_wait(chan, "vm-ingen");
               res = res ? res : ast_play_and_wait(chan, "vm-messages");
               return res;
       }


This will break existing voicemail-configurations, if they have recorded "ingen" into the vm-no.gsm file.
Comments:By: Paul Belanger (pabelanger) 2010-06-17 09:17:21

Like you said, your patch will break alot of system in the wild, why not simply re-record 'vm-no' properly?
By: Marius (mariussm) 2010-06-18 01:41:54

Might I suggest the following:


       if (!vms->oldmessages && !vms->newmessages && !vms->urgentmessages) {
               /* Fix for correct language, without breaking previous behaviour */
               if(ast_fileexists("vm-ingen",NULL,"no")) {
                       res = ast_play_and_wait(chan, "vm-ingen");
               } else {
                       res = ast_play_and_wait(chan, "vm-no");
               }
               res = res ? res : ast_play_and_wait(chan, "vm-messages");
               return res;
       }


This will NOT break current behaviour.
By: Paul Belanger (pabelanger) 2010-06-18 06:07:10

The correct method would be to re-record 'vm-no' and update your packaging,  since it appears to be wrong.  Since we don't have access to those prompts, you will have to make the changes.