Summary:	ASTERISK-16249: [patch] prematuremedia and progress inband
Reporter:	Martin Vit (festr)	Labels:
Date Opened:	2010-06-16 10:46:32	Date Closed:	2010-07-06 17:30:06
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) patch
Description:	In configs/sip.conf.sample, premature media is documented like this: ----- Setting this to "no" will stop any media before we have call progress. Default is "yes". ----- but in channels/chan_sip.c default is FALSE and chan_sip.c is testing it like this: if (!global_prematuremediafilter) { send 183 } so the documentation is wrong. ****** ADDITIONAL INFORMATION ****** I've ISDN30 which sends ALERT (not progress inband) and asterisk sends in SIP 183 with silence frames. I had to set prematuremedia to YES and progressinband=never. I'm also suggesting to put note to set progressinband=never along prematuremedia=yes (and maybe also it should be noted that it is global variable which is not optimal, because I want only one SIP channel to filter 183 progress, not all channels).
Comments:	By: Paul Belanger (pabelanger) 2010-06-16 14:11:47 Are you able to provide a patch? By: Martin Vit (festr) 2010-06-16 15:07:57 Yes, I'll provide it tomorrow. By: Martin Vit (festr) 2010-06-17 02:43:23 I've uploaded patch, but please review english as it is not my native language. By: Leif Madsen (lmadsen) 2010-06-17 13:18:56 Marking as Confirmed until we determine that the docs are wrong and the code right (and not vice-versa) By: Digium Subversion (svnbot) 2010-07-06 17:15:21 Repository: asterisk Revision: 274283 U   branches/1.4/configs/sip.conf.sample ------------------------------------------------------------------------ r274283 | jpeeler | 2010-07-06 17:15:20 -0500 (Tue, 06 Jul 2010) | 7 lines Correct sip.conf.sample comments for prematuremedia option. (closes issue ASTERISK-16249) Reported by: festr Patches:      patch uploaded by festr (license 443) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=274283 By: Digium Subversion (svnbot) 2010-07-06 17:23:34 Repository: asterisk Revision: 274316 _U  trunk/ U   trunk/configs/sip.conf.sample ------------------------------------------------------------------------ r274316 | jpeeler | 2010-07-06 17:23:34 -0500 (Tue, 06 Jul 2010) | 14 lines Merged revisions 274283 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r274283 | jpeeler | 2010-07-06 17:15:21 -0500 (Tue, 06 Jul 2010) | 7 lines    Correct sip.conf.sample comments for prematuremedia option.    (closes issue ASTERISK-16249)  Reported by: festr  Patches:        patch uploaded by festr (license 443) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=274316 By: Digium Subversion (svnbot) 2010-07-06 17:30:05 Repository: asterisk Revision: 274347 _U  branches/1.6.2/ U   branches/1.6.2/configs/sip.conf.sample ------------------------------------------------------------------------ r274347 | jpeeler | 2010-07-06 17:30:05 -0500 (Tue, 06 Jul 2010) | 21 lines Merged revisions 274316 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r274316 | jpeeler | 2010-07-06 17:23:35 -0500 (Tue, 06 Jul 2010) | 14 lines    Merged revisions 274283 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r274283 | jpeeler | 2010-07-06 17:15:21 -0500 (Tue, 06 Jul 2010) | 7 lines        Correct sip.conf.sample comments for prematuremedia option.        (closes issue ASTERISK-16249)    Reported by: festr    Patches:          patch uploaded by festr (license 443)  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=274347