Summary:	ASTERISK-16240: [patch] ShowDialPlan does not end with ShowDialPlanComplete Event if manager events are off
Reporter:	Ryan Bullock (rrb3942)	Labels:
Date Opened:	2010-06-14 10:14:45	Date Closed:	2010-07-06 15:08:46
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Core/ManagerInterface
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) showdialplan_patch.diff
Description:	The 'ShowDialPlanComplete' event is not sent to the manager session if events are not enabled (specifically config events). It also appears that it sends this event out on all manager connections with config events enabled which could cause some problems with ActionIDs across multiple manager connections.
Comments:	By: Ryan Bullock (rrb3942) 2010-06-14 10:33:55 The attached patch causes the 'ShowDialPlanComplete' event to be sent out on the manager session regardless of event settings. It also only sends it out on the manager session that issued the 'ShowDialPlan' action. By: Digium Subversion (svnbot) 2010-06-29 17:39:22 Repository: asterisk Revision: 273054 U   trunk/main/pbx.c ------------------------------------------------------------------------ r273054 | tilghman | 2010-06-29 17:39:21 -0500 (Tue, 29 Jun 2010) | 11 lines Send DialPlanComplete as a response, not as a separate event. Otherwise, it goes to all manager sessions and may exclude the current session, if the Events mask excludes it. (closes issue ASTERISK-16240) Reported by: rrb3942 Patches:       showdialplan_patch.diff uploaded by rrb3942 (license 1003) Tested by: rrb3942 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=273054 By: Digium Subversion (svnbot) 2010-06-29 17:41:16 Repository: asterisk Revision: 273056 _U  branches/1.6.2/ U   branches/1.6.2/main/pbx.c ------------------------------------------------------------------------ r273056 | tilghman | 2010-06-29 17:41:15 -0500 (Tue, 29 Jun 2010) | 18 lines Merged revisions 273054 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r273054 | tilghman | 2010-06-29 17:39:22 -0500 (Tue, 29 Jun 2010) | 11 lines    Send DialPlanComplete as a response, not as a separate event.    Otherwise, it goes to all manager sessions and may exclude the current session,  if the Events mask excludes it.    (closes issue ASTERISK-16240)   Reported by: rrb3942   Patches:         showdialplan_patch.diff uploaded by rrb3942 (license 1003)   Tested by: rrb3942 ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=273056