Summary:ASTERISK-16216: [patch] Replace old stub functions with new optional_api functions
Reporter:Tilghman Lesher (tilghman)Labels:
Date Opened:2010-06-05 14:25:37Date Closed:2010-07-15 13:45:19
Versions:Frequency of
Environment:Attachments:( 0) 20100605__issue17475.diff.txt
Description:Previously, we created stub function files for modules that were dependencies  but were often not used.  Now, we have a better API for doing so, which does not require stub function pointers to exist, but uses the ELF symbol tables instead.
Comments:By: Digium Subversion (svnbot) 2010-07-14 16:25:13

Repository: asterisk
Revision: 276490

U   trunk/include/asterisk/adsi.h
U   trunk/include/asterisk/agi.h
U   trunk/include/asterisk/crypto.h
U   trunk/include/asterisk/optional_api.h
U   trunk/main/Makefile
D   trunk/main/adsistub.c
U   trunk/main/asterisk.dynamics
D   trunk/main/cryptostub.c
U   trunk/main/loader.c
U   trunk/res/res_adsi.c
U   trunk/res/res_adsi.exports.in
U   trunk/res/res_crypto.c
A   trunk/res/res_crypto.exports.in
U   trunk/tests/test_utils.c

r276490 | tilghman | 2010-07-14 16:25:12 -0500 (Wed, 14 Jul 2010) | 7 lines

Remove the old stub files, preferring the optional_api method.

(closes issue ASTERISK-16216)
Reported by: tilghman

Review: https://reviewboard.asterisk.org/r/695/



By: Leif Madsen (lmadsen) 2010-07-15 07:17:02

I get a compile issue that is likely related to this commit:

  [AR] hash/hash.o hash/hash_bigkey.o hash/hash_buf.o hash/hash_func.o hash/hash_log2.o hash/hash_page.o hash/ndbm.o btree/bt_close.o btree/bt_conv.o btree/bt_debug.o btree/bt_delete.o btree/bt_get.o btree/bt_open.o btree/bt_overflow.o btree/bt_page.o btree/bt_put.o btree/bt_search.o btree/bt_seq.o btree/bt_split.o btree/bt_utils.o db/db.o mpool/mpool.o recno/rec_close.o recno/rec_delete.o recno/rec_get.o recno/rec_open.o recno/rec_put.o recno/rec_search.o recno/rec_seq.o recno/rec_utils.o -> libdb1.a
  [LD] abstract_jb.o acl.o aescrypt.o aeskey.o aestab.o alaw.o aoc.o app.o ast_expr2.o ast_expr2f.o asterisk.o astfd.o astmm.o astobj2.o audiohook.o autochan.o autoservice.o bridging.o callerid.o ccss.o cdr.o cel.o channel.o chanvars.o cli.o config.o data.o datastore.o db.o devicestate.o dial.o dns.o dnsmgr.o dsp.o enum.o event.o features.o file.o fixedjitterbuf.o frame.o fskmodem.o global_datastores.o hashtab.o heap.o http.o image.o indications.o io.o jitterbuf.o loader.o lock.o logger.o manager.o md5.o netsock.o netsock2.o pbx.o plc.o poll.o privacy.o rtp_engine.o say.o sched.o security_events.o sha1.o slinfactory.o srv.o ssl.o stdtime/localtime.o strcompat.o strings.o stun.o syslog.o taskprocessor.o tcptls.o tdd.o term.o test.o threadstorage.o timing.o translate.o udptl.o ulaw.o utils.o version.o xml.o xmldoc.o editline/libedit.a db1-ast/libdb1.a  -> asterisk
features.o: In function `park_call_full':
/usr/src/asterisk-complete/asterisk/1.8/main/features.c:969: undefined reference to `ast_adsi_available'
features.o: In function `adsi_announce_park':
/usr/src/asterisk-complete/asterisk/1.8/main/features.c:617: undefined reference to `ast_adsi_load_session'
/usr/src/asterisk-complete/asterisk/1.8/main/features.c:620: undefined reference to `ast_adsi_print'
features.o: In function `park_call_full':
/usr/src/asterisk-complete/asterisk/1.8/main/features.c:971: undefined reference to `ast_adsi_unload_session'
collect2: ld returned 1 exit status
make[1]: *** [asterisk] Error 1
make: *** [main] Error 2

CentOS 5.4 (Final) on i686

By: Tilghman Lesher (tilghman) 2010-07-15 10:13:51

Please to be:

touch main/features.c