[Home]

Summary:ASTERISK-16212: [patch] "joinempty = ringing" doesn't work
Reporter:jazzy (jazzy)Labels:
Date Opened:2010-06-05 06:28:06Date Closed:2010-07-16 14:24:38
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.c.diff
Description:I want to prevent placing a call to a queue when all members are busy or unavailable. A caller is placed to a queue despite "joinempty = ringing" setting and the fact that the members' phone is already ringing.
Tested under Ubuntu 10.04 LTS with fresh install and asterisk 1.6.2.5 from ubuntu packages.
Other settings of joinempty parameter work fine (unavailable, inuse).
Only few changes to the default configuration was made to reproduce this bug:


In sip.conf:

callcounter = yes

[1001]
type=friend
secret=1001
host=dynamic

[1002]
type=friend
secret=1002
host=dynamic

[1003]
type=friend
secret=1003
host=dynamic


In extensions.conf inside default context:

exten => 1001,1,Dial(SIP/1001)
exten => 1002,1,Dial(SIP/1002)
exten => 1003,1,Dial(SIP/1003)
exten => 1004,1,Queue(operators)
exten => 1004,n,Hangup()


In queues.conf:

[operators]
joinempty = unavailable,inuse,ringing
member => SIP/1003


Then call from 1001 to 1003 and while it's ringing, call from 1002 to 1004. The call will be placed to the queue.

****** ADDITIONAL INFORMATION ******

I also can reproduce it on 1.6.2.9-rc1 with fresh install from sources (configure; make; make install; make samples).
Comments:By: jazzy (jazzy) 2010-06-06 05:52:37

I looked into app_queue.c source code (get_member_status function) and found that the ringing functionality is not implemented. Here is the trivial patch to resolve this issue.

<inline patch removed by lmadsen>


By: Leif Madsen (lmadsen) 2010-06-09 10:09:59

Hey jazzy!

Thanks for the patch for functionality that appears should be present :)

However we can't accept patches which are pasted inline. Could you attach that patch after you have signed the electronic license agreement? (if you haven't already).

It should be a link at the top of the page, and you will only need to do it once.

Thanks!
By: jazzy (jazzy) 2010-06-09 10:20:11

Hi lmadsen,

I attached the patch as a file.
By: Digium Subversion (svnbot) 2010-07-16 14:22:49

Repository: asterisk
Revision: 277366

U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r277366 | jpeeler | 2010-07-16 14:22:48 -0500 (Fri, 16 Jul 2010) | 7 lines

Add missing handling for ringing state for use with queue empty options.

(closes issue ASTERISK-16212)
Reported by: jazzy
Patches:
     app_queue.c.diff uploaded by jazzy (license 1056)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277366
By: Digium Subversion (svnbot) 2010-07-16 14:24:37

Repository: asterisk
Revision: 277377

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_queue.c

------------------------------------------------------------------------
r277377 | jpeeler | 2010-07-16 14:24:37 -0500 (Fri, 16 Jul 2010) | 14 lines

Merged revisions 277366 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r277366 | jpeeler | 2010-07-16 14:22:49 -0500 (Fri, 16 Jul 2010) | 7 lines
 
 Add missing handling for ringing state for use with queue empty options.
 
 (closes issue ASTERISK-16212)
 Reported by: jazzy
 Patches:
       app_queue.c.diff uploaded by jazzy (license 1056)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277377