Summary:	ASTERISK-16211: [patch] sort=alpha does not start at position 0
Reporter:	Paul Belanger (pabelanger)	Labels:
Date Opened:	2010-06-04 12:58:43	Date Closed:	2010-06-14 16:38:27
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_musiconhold
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) sort.aplha.patch
Description:	Leif found this bug, but I fixed it :) Seems when you set sort=alpha, it will always play start + 1 file first. ****** ADDITIONAL INFORMATION ****** Attach patch should fix it.
Comments:	By: Leif Madsen (lmadsen) 2010-06-07 12:32:02 Here is an example: [foobar] mode=files directory=/var/spool/asterisk/moh/foobar sort=alpha By: Leif Madsen (lmadsen) 2010-06-14 13:00:10 Looks I didn't report back. I patched and tested this and it works! By: Digium Subversion (svnbot) 2010-06-14 16:31:59 Repository: asterisk Revision: 270331 U   branches/1.4/res/res_musiconhold.c ------------------------------------------------------------------------ r270331 | pabelanger | 2010-06-14 16:31:59 -0500 (Mon, 14 Jun 2010) | 14 lines Properly play first file in sort list. When using sort=alpha we would always skip the first file in the list first time through.  We now check for that properly. (closes issue ASTERISK-16211) Reported by: pabelanger Patches:      sort.aplha.patch uploaded by pabelanger (license 224) Tested by: lmadsen Review: [full review board URL with trailing slash] ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=270331 By: Digium Subversion (svnbot) 2010-06-14 16:33:55 Repository: asterisk Revision: 270332 _U  trunk/ U   trunk/res/res_musiconhold.c ------------------------------------------------------------------------ r270332 | pabelanger | 2010-06-14 16:33:54 -0500 (Mon, 14 Jun 2010) | 21 lines Merged revisions 270331 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r270331 | pabelanger | 2010-06-14 17:31:59 -0400 (Mon, 14 Jun 2010) | 14 lines    Properly play first file in sort list.    When using sort=alpha we would always skip the first file  in the list first time through.  We now check for that  properly.    (closes issue ASTERISK-16211)  Reported by: pabelanger  Patches:        sort.aplha.patch uploaded by pabelanger (license 224)  Tested by: lmadsen    Review: https://reviewboard.asterisk.org/r/703/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=270332 By: Digium Subversion (svnbot) 2010-06-14 16:35:52 Repository: asterisk Revision: 270333 U   branches/1.6.2/res/res_musiconhold.c ------------------------------------------------------------------------ r270333 | pabelanger | 2010-06-14 16:35:52 -0500 (Mon, 14 Jun 2010) | 28 lines Merged revisions 270332 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r270332 | pabelanger | 2010-06-14 17:33:55 -0400 (Mon, 14 Jun 2010) | 21 lines    Merged revisions 270331 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r270331 | pabelanger | 2010-06-14 17:31:59 -0400 (Mon, 14 Jun 2010) | 14 lines        Properly play first file in sort list.        When using sort=alpha we would always skip the first file    in the list first time through.  We now check for that    properly.        (closes issue ASTERISK-16211)    Reported by: pabelanger    Patches:          sort.aplha.patch uploaded by pabelanger (license 224)    Tested by: lmadsen        Review: https://reviewboard.asterisk.org/r/703/  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=270333 By: Digium Subversion (svnbot) 2010-06-14 16:38:27 Repository: asterisk Revision: 270331 U   branches/1.4/res/res_musiconhold.c ------------------------------------------------------------------------ r270331 | pabelanger | 2010-06-14 16:31:59 -0500 (Mon, 14 Jun 2010) | 14 lines Properly play first file in sort list. When using sort=alpha we would always skip the first file in the list first time through.  We now check for that properly. (closes issue ASTERISK-16211) Reported by: pabelanger Patches:      sort.aplha.patch uploaded by pabelanger (license 224) Tested by: lmadsen Review: https://reviewboard.asterisk.org/r/703/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=270331