[Home]

Summary:ASTERISK-16145: [patch] [regression] r263292 breaks zaptel compatibility so Asterisk fails to make.
Reporter:David Brillert (aragon)Labels:
Date Opened:2010-05-25 09:26:22Date Closed:2010-05-25 12:12:28
Priority:BlockerRegression?Yes
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) half_buffer_fix.diff
Description:Fresh checkout of 1.4 r265569
Asterisk fails to make if Zaptel is installed


****** STEPS TO REPRODUCE ******

Dahdi not installed.
Zaptel 1.4.12 installed

svn co (current release r265569)
./configure
make

Produces error during make

Generating embedded module rules ...
  [CC] chan_dahdi.c -> chan_dahdi.o
chan_dahdi.c: In function âparse_buffers_policyâ:
chan_dahdi.c:3472: error: âDAHDI_POLICY_HALF_FULLâ undeclared (first use in this function)
chan_dahdi.c:3472: error: (Each undeclared identifier is reported only once
chan_dahdi.c:3472: error: for each function it appears in.)
make[1]: *** [chan_dahdi.o] Error 1

****** ADDITIONAL INFORMATION ******

Reverting r263292 fixes Zaptel compatibility.

svn diff -r 263291:263292 channels/chan_dahdi.c > 263292.diff

patch -R -p0 < 263292.diff

After reverting r263292 Asterisk installs clean.
Comments:By: Paul Belanger (pabelanger) 2010-05-25 09:35:55

What is the actually error you see on make?
By: David Brillert (aragon) 2010-05-25 09:40:52

pabelanger:  If you switch to advanced view and check...
Steps To Reproduce:
Dahdi not installed.
Zaptel 1.4.12 installed

svn co (current release r265569)
./configure
make

Produces error during make

Generating embedded module rules ...
  [CC] chan_dahdi.c -> chan_dahdi.o
chan_dahdi.c: In function âparse_buffers_policyâ:
chan_dahdi.c:3472: error: âDAHDI_POLICY_HALF_FULLâ undeclared (first use in this function)
chan_dahdi.c:3472: error: (Each undeclared identifier is reported only once
chan_dahdi.c:3472: error: for each function it appears in.)
make[1]: *** [chan_dahdi.o] Error 1
By: Paul Belanger (pabelanger) 2010-05-25 09:46:54

aragon: heh, didn't realize that was even there.  Thanks for the info.

Looks to be a bug. :)
By: David Brillert (aragon) 2010-05-25 10:03:46

Additional info:
Reverting r263292 allows Asterisk to make and install but Asterisk fails to see my PRI cards.  IMHO there must be another bug somewhere else too.

Connected to Asterisk SVN-branch-1.4-r265570M currently running on lab (pid = 4739)
Verbosity is at least 3
Core debug is at least 3
lab*CLI> pri show spans
No such command 'pri show spans' (type 'help pri show' for other possible commands)
lab*CLI>
By: David Vossel (dvossel) 2010-05-25 10:21:26

Uploaded a patch, please verify this resolves the issue.
By: David Brillert (aragon) 2010-05-25 11:04:07

Tested the patch and Asterisk installs clean.
Still having issues with my PRI cards...
No errors in dmesg or errors starting zaptel service.

Connected to Asterisk SVN-branch-1.4-r265570M currently running on lab (pid = 17360)
Verbosity is at least 3
Core debug is at least 3
lab*CLI> pri show spans
No such command 'pri show spans' (type 'help pri show' for other possible commands)
lab*CLI>

/etc/zaptel.conf
loadzone        =  us
defaultzone     =  us
span            =  1,1,0,esf,b8zs
bchan           =  01-23
hardhdlc        =  24
span            =  2,2,0,esf,b8zs
bchan           =  25-47
hardhdlc        =  48
span            =  3,3,0,esf,b8zs
bchan           =  49-71
hardhdlc        =  72
span            =  4,4,0,esf,b8zs
bchan           =  73-95
hardhdlc        =  96

/etc/asterisk/zapata.conf
[channels]
jbenable                  =  no
language                  =  en
resetinterval             =  never
priindication             =  outofband
switchtype                =  national
signalling                =  pri_net
pridialplan               =  unknown
prilocaldialplan          =  national
facilityenable            =  yes
transfer                  =  no
accountcode               =  _NONE_
amaflags                  =  default
relaxdtmf                 =  yes
echocancel                =  128
echocancelwhenbridged     =  yes
overlapdial               =  no
echotraining              =  400
context                   =  zap-incoming
group                     =  1,3,6
channel                   => 01-23
language                  =  en
resetinterval             =  never
priindication             =  outofband
switchtype                =  national
signalling                =  pri_net
pridialplan               =  unknown
prilocaldialplan          =  national
facilityenable            =  yes
transfer                  =  no
accountcode               =  _NONE_
amaflags                  =  default
relaxdtmf                 =  yes
echocancel                =  128
echocancelwhenbridged     =  yes
overlapdial               =  no
echotraining              =  400
context                   =  zap-incoming
group                     =  2,3,6
channel                   => 25-47
language                  =  en
resetinterval             =  never
priindication             =  outofband
switchtype                =  national
signalling                =  pri_net
pridialplan               =  unknown
prilocaldialplan          =  national
facilityenable            =  yes
transfer                  =  no
accountcode               =  _NONE_
amaflags                  =  default
relaxdtmf                 =  yes
echocancel                =  128
echocancelwhenbridged     =  yes
overlapdial               =  no
echotraining              =  400
context                   =  zap-incoming
group                     =  3,6
channel                   => 49-71
language                  =  en
resetinterval             =  never
priindication             =  outofband
switchtype                =  national
signalling                =  pri_net
pridialplan               =  unknown
prilocaldialplan          =  national
facilityenable            =  yes
transfer                  =  no
accountcode               =  _NONE_
amaflags                  =  default
relaxdtmf                 =  yes
echocancel                =  128
echocancelwhenbridged     =  yes
overlapdial               =  no
echotraining              =  400
context                   =  zap-incoming
group                     =  3,4,6
channel                   => 73-95
By: David Brillert (aragon) 2010-05-25 11:59:24

I'm not sure how to debug the pri spans problem...
So I tried downgrading to r262662.
I did see this notice when forcing a reload.
But my spans should be running in network mode and not cpe.

[2010-05-25 12:56:48] ERROR[21219]: chan_dahdi.c:11778 process_dahdi: Unknown signalling method 'pri_net'
[2010-05-25 12:56:48] ERROR[21219]: chan_dahdi.c:11328 build_channels: Signalling must be specified before any channels are.

I have a feeling this is a separate issue not related to my original bug report.


By: Digium Subversion (svnbot) 2010-05-25 12:11:40

Repository: asterisk
Revision: 265613

U   branches/1.4/channels/chan_dahdi.c

------------------------------------------------------------------------
r265613 | dvossel | 2010-05-25 12:11:39 -0500 (Tue, 25 May 2010) | 8 lines

fixes build issue with zaptel

(closes issue ASTERISK-16145)
Reported by: aragon
Patches:
     half_buffer_fix.diff uploaded by dvossel (license 671)
Tested by: aragon

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265613
By: Digium Subversion (svnbot) 2010-05-25 12:12:28

Repository: asterisk
Revision: 265614

_U  trunk/

------------------------------------------------------------------------
r265614 | dvossel | 2010-05-25 12:12:28 -0500 (Tue, 25 May 2010) | 14 lines

Blocked revisions 265613 via svnmerge

........
 r265613 | dvossel | 2010-05-25 12:11:40 -0500 (Tue, 25 May 2010) | 8 lines
 
 fixes build issue with zaptel
 
 (closes issue ASTERISK-16145)
 Reported by: aragon
 Patches:
       half_buffer_fix.diff uploaded by dvossel (license 671)
 Tested by: aragon
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265614