[Home]

Summary:ASTERISK-16142: [patch] latest trunk doesn't compile
Reporter:Ronald Chan (loloski)Labels:
Date Opened:2010-05-24 22:17:47Date Closed:2010-05-26 00:33:12
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_calendar
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue17391.patch.v2
Description:res_calendar_ews.c: In function âsend_ews_request_and_parseâ:
res_calendar_ews.c:463: warning: implicit declaration of function âne_set_request_flagâ
res_calendar_ews.c:463: error: âNE_REQFLAG_IDEMPOTENTâ undeclared (first use in this function)
res_calendar_ews.c:463: error: (Each undeclared identifier is reported only once
res_calendar_ews.c:463: error: for each function it appears in.)
make[1]: *** [res_calendar_ews.o] Error 1
make: *** [res] Error 2


****** ADDITIONAL INFORMATION ******

I can't set a category because this is a new feature
Comments:By: Ronald Chan (loloski) 2010-05-25 04:50:59

------------------------------------------------------------------------
r265317 | twilson | 2010-05-25 02:21:20 +0800 (Tue, 25 May 2010) | 15 lines

Calendaring support for Exchange Server 2007+ via EWS

This commit adds support for calendaring with Exchange Server 2007+ via
Exchange Web Services. Full write support and for querying attendees. Many
thanks to Jan Kaláb for the feature.

(closes issue ASTERISK-15804)
Reported by: pitel
Patches:
     res_calendar_ews.c uploaded by pitel (license 1008)
Tested by: pitel, twilson

Review: https://reviewboard.asterisk.org/r/557/
Review: https://reviewboard.asterisk.org/r/668/

can someone verify this, i full down the latest source from svn and it won't compile
By: Paul Belanger (pabelanger) 2010-05-25 08:34:31

Attach your config.log
By: Terry Wilson (twilson) 2010-05-25 14:09:30

Actually, you just need to make sure that you have libneon >= 0.29.0 (preferably 0.29.1+)


By: Ronald Chan (loloski) 2010-05-25 14:24:19

The distribution in question was Centos 5.4, if that so, please don't enable this by default if libneon requirement was not met. because it will cause confusion for starters that it won't compile. there are a lot of * users out there using less bleeding edge distribution like centos just imho.
By: Ronald Chan (loloski) 2010-05-25 14:30:19

[root@pbx ~]# cat /etc/issue
CentOS release 5.4 (Final)
Kernel \r on an \m

[root@pbx ~]#

[root@pbx ~]# rpm -qa | grep neon-devel
neon-devel-0.25.5-10.el5_4.1

[root@pbx ~]#
By: Terry Wilson (twilson) 2010-05-25 16:21:06

I'll work on revamping the autoconf stuff for the res_calendar_ews stuff.
By: Paul Belanger (pabelanger) 2010-05-25 16:28:39

What about something like this? Wanted to try my autoconf skills ;)

Edit: Deleted patch, needs a little more testing.


By: Paul Belanger (pabelanger) 2010-05-25 16:46:55

Version 2:

Not sure if this is the best approach, but seems to work with CentOS.  Still needs to be tested on other systems.
By: Ronald Chan (loloski) 2010-05-25 17:03:15

after applying the patch, it still fails to compile on centos 5.4

res_calendar_ews.c: In function âsend_ews_request_and_parseâ:
res_calendar_ews.c:463: warning: implicit declaration of function âne_set_reques                                                                                                                               t_flagâ
res_calendar_ews.c:463: error: âNE_REQFLAG_IDEMPOTENTâ undeclared (first use in                                                                                                                                this function)
res_calendar_ews.c:463: error: (Each undeclared identifier is reported only once
res_calendar_ews.c:463: error: for each function it appears in.)
make[1]: *** [res_calendar_ews.o] Error 1
make: *** [res] Error 2
By: Ronald Chan (loloski) 2010-05-25 17:09:26

Or i might say I overlook what's really the patch is trying to accomplish, but what i can say when i apply the patch then i check menuselect selection, still it doesn't flag this res_calendar_ews to be unavailable because it doesn't met the required libneon library.

please bare with me if i say irrelevant things, because i'm not really a developer to understand what the patch is trying to do.
By: Digium Subversion (svnbot) 2010-05-25 19:29:40

Repository: asterisk
Revision: 265747

U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in
U   trunk/pbx/pbx_lua.c
U   trunk/res/res_calendar_caldav.c
U   trunk/res/res_calendar_ews.c
U   trunk/res/res_calendar_exchange.c
U   trunk/res/res_calendar_icalendar.c

------------------------------------------------------------------------
r265747 | tilghman | 2010-05-25 19:29:40 -0500 (Tue, 25 May 2010) | 8 lines

Use configure to determine the prefixes and include directories properly.

This ensures cross-platform compatibility, even among Linux distributions,
which don't always put headers in the same place.

(closes issue ASTERISK-16142)
Reported by: loloski

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265747
By: Digium Subversion (svnbot) 2010-05-25 19:33:49

Repository: asterisk
Revision: 265748

_U  branches/1.6.2/
U   branches/1.6.2/configure
U   branches/1.6.2/configure.ac
U   branches/1.6.2/include/asterisk/autoconfig.h.in
U   branches/1.6.2/pbx/pbx_lua.c

------------------------------------------------------------------------
r265748 | tilghman | 2010-05-25 19:33:49 -0500 (Tue, 25 May 2010) | 15 lines

Merged revisions 265747 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r265747 | tilghman | 2010-05-25 19:29:40 -0500 (Tue, 25 May 2010) | 8 lines
 
 Use configure to determine the prefixes and include directories properly.
 
 This ensures cross-platform compatibility, even among Linux distributions,
 which don't always put headers in the same place.
 
 (closes issue ASTERISK-16142)
  Reported by: loloski
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265748
By: Digium Subversion (svnbot) 2010-05-26 00:33:11

Repository: asterisk
Revision: 265793

U   trunk/build_tools/menuselect-deps.in
U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in
U   trunk/res/res_calendar_ews.c

------------------------------------------------------------------------
r265793 | twilson | 2010-05-26 00:33:11 -0500 (Wed, 26 May 2010) | 12 lines

Ensure that libneon > 0.29.0 is installed for res_calendar_ews

This uses a modified version of pabelanger's patch that checks for NTLM support
instead, which was added in 0.29.0 which is what is required for
res_calendar_ews.

(closes issue ASTERISK-16142)
Reported by: loloski
Patches:
     issue17391.patch.v2 uploaded by pabelanger (license 224)
Tested by: twilson

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265793