[Home]

Summary:ASTERISK-16071: AST_EXT_LIB_CHECK doesn't use [extra cflags]
Reporter:Stuart Henderson (stuarth)Labels:
Date Opened:2010-05-08 20:01:54Date Closed:2010-05-08 21:17:18
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Various checks pass extra cflags into AST_EXT_LIB_CHECK, notably for pthread libs. These aren't used when calling AC_CHECK_LIB, so some checks fail which should succeed (e.g. iodbc, spandsp).

****** ADDITIONAL INFORMATION ******

--- autoconf/ast_ext_lib.m4.orig Sun May  9 01:52:51 2010
+++ autoconf/ast_ext_lib.m4 Sun May  9 01:52:53 2010
@@ -81,7 +81,10 @@ if test "x${PBX_$1}" != "x1" -a "${USE_$1}" != "no"; t
   if test "x${pbxfuncname}" = "x" ; then   # empty lib, assume only headers
      AST_$1_FOUND=yes
   else
+      checklib_save_cflags="${CFLAGS}"
+      CFLAGS="${CFLAGS} $6"
      AC_CHECK_LIB([$2], [${pbxfuncname}], [AST_$1_FOUND=yes], [AST_$1_FOUND=no], ${pbxlibdir} $5)
+      CFLAGS="${checklib_save_cflags}"
   fi

   # now check for the header.
Comments:By: Digium Subversion (svnbot) 2010-05-08 21:14:05

Repository: asterisk
Revision: 262102

U   trunk/autoconf/ast_c_compile_check.m4
U   trunk/autoconf/ast_c_define_check.m4
U   trunk/autoconf/ast_ext_lib.m4
U   trunk/configure
U   trunk/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r262102 | tilghman | 2010-05-08 21:14:04 -0500 (Sat, 08 May 2010) | 5 lines

Cleanup a bit more by getting rid of useless version defines. Also make library detection use passed CFLAGS.

(closes issue ASTERISK-16071)
Reported by: stuarth

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262102
By: Digium Subversion (svnbot) 2010-05-08 21:17:01

Repository: asterisk
Revision: 262103

_U  branches/1.6.0/
U   branches/1.6.0/autoconf/ast_c_compile_check.m4
U   branches/1.6.0/autoconf/ast_c_define_check.m4
U   branches/1.6.0/autoconf/ast_ext_lib.m4
U   branches/1.6.0/configure
U   branches/1.6.0/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r262103 | tilghman | 2010-05-08 21:17:00 -0500 (Sat, 08 May 2010) | 12 lines

Merged revisions 262102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r262102 | tilghman | 2010-05-08 21:14:04 -0500 (Sat, 08 May 2010) | 5 lines
 
 Cleanup a bit more by getting rid of useless version defines. Also make library detection use passed CFLAGS.
 
 (closes issue ASTERISK-16071)
  Reported by: stuarth
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262103
By: Digium Subversion (svnbot) 2010-05-08 21:17:10

Repository: asterisk
Revision: 262104

_U  branches/1.6.1/
U   branches/1.6.1/autoconf/ast_c_compile_check.m4
U   branches/1.6.1/autoconf/ast_c_define_check.m4
U   branches/1.6.1/autoconf/ast_ext_lib.m4
U   branches/1.6.1/configure
U   branches/1.6.1/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r262104 | tilghman | 2010-05-08 21:17:10 -0500 (Sat, 08 May 2010) | 12 lines

Merged revisions 262102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r262102 | tilghman | 2010-05-08 21:14:04 -0500 (Sat, 08 May 2010) | 5 lines
 
 Cleanup a bit more by getting rid of useless version defines. Also make library detection use passed CFLAGS.
 
 (closes issue ASTERISK-16071)
  Reported by: stuarth
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262104
By: Digium Subversion (svnbot) 2010-05-08 21:17:18

Repository: asterisk
Revision: 262105

_U  branches/1.6.2/
U   branches/1.6.2/autoconf/ast_c_compile_check.m4
U   branches/1.6.2/autoconf/ast_c_define_check.m4
U   branches/1.6.2/autoconf/ast_ext_lib.m4
U   branches/1.6.2/configure
U   branches/1.6.2/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r262105 | tilghman | 2010-05-08 21:17:17 -0500 (Sat, 08 May 2010) | 12 lines

Merged revisions 262102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r262102 | tilghman | 2010-05-08 21:14:04 -0500 (Sat, 08 May 2010) | 5 lines
 
 Cleanup a bit more by getting rid of useless version defines. Also make library detection use passed CFLAGS.
 
 (closes issue ASTERISK-16071)
  Reported by: stuarth
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262105