[Home]

Summary:ASTERISK-16034: [patch] Failed to register peers from realtime config
Reporter:nick_lewis (nick_lewis)Labels:
Date Opened:2010-04-30 07:14:01Date Closed:2010-05-05 14:19:14
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip.c-realtime.patch
Description:The resulting messages are:

>WARNING[27221]: acl.c:383 ast_get_ip_or_srv: Unable to lookup ''
>
> NOTICE[27221]: chan_sip.c:20603 handle_request_register: Registration from
> '" voipphone1"<sip:voipphone1@10.0.0.10:5060>' failed for '10.0.0.20' - No
> matching peer found
>

And the peers are not registered...
On MySQL DB, the table was created as described in http://www.voip-info.org/wiki/view/Asterisk+RealTime+Sip



****** ADDITIONAL INFORMATION ******

This error appeared when field "defaultip" on table sip peers is blank or NULL (set to 0.0.0.0 solve the problem).
Comments:By: nick_lewis (nick_lewis) 2010-04-30 07:15:56

Please find attached a patch that may help. I hope Serge Berney may be able to test it
By: Serge Berney (sberney) 2010-04-30 09:10:29

Warning, seems that there's a missing ending } at line 13 on your patch !!!
By: Paul Belanger (pabelanger) 2010-04-30 09:47:09

I'm not seeing what you are referencing.  Are you able to make the change locally and upload the new diff?
By: Serge Berney (sberney) 2010-04-30 10:03:54

I'm sorry, I made a mistake... nothing was wrong.

So I tested the patch and issue it now solved !!!

Thanks !
By: nick_lewis (nick_lewis) 2010-05-04 03:40:16

I am glad this helped. As it has been tested successfully by sberney perhaps a committer could add it to trunk
By: Russell Bryant (russell) 2010-05-04 09:19:11

Needs spaces after "if".  Other than that, "ship it"
By: Digium Subversion (svnbot) 2010-05-05 11:42:23

Repository: asterisk
Revision: 261274

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r261274 | pabelanger | 2010-05-05 11:42:22 -0500 (Wed, 05 May 2010) | 12 lines

Registration fix for SIP realtime.

Make sure realtime fields are not empty.

(closes issue ASTERISK-16034)
Reported by: Nick_Lewis
Patches:
     chan_sip.c-realtime.patch uploaded by Nick Lewis (license 657)
Tested by: Nick_Lewis, sberney

Review: https://reviewboard.asterisk.org/r/643/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=261274
By: Digium Subversion (svnbot) 2010-05-05 13:43:04

Repository: asterisk
Revision: 261314

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r261314 | pabelanger | 2010-05-05 13:43:03 -0500 (Wed, 05 May 2010) | 19 lines

Merged revisions 261274 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r261274 | pabelanger | 2010-05-05 12:42:22 -0400 (Wed, 05 May 2010) | 12 lines
 
 Registration fix for SIP realtime.
 
 Make sure realtime fields are not empty.
 
 (closes issue ASTERISK-16034)
 Reported by: Nick_Lewis
 Patches:
       chan_sip.c-realtime.patch uploaded by Nick Lewis (license 657)
 Tested by: Nick_Lewis, sberney
 
 Review: https://reviewboard.asterisk.org/r/643/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=261314
By: Digium Subversion (svnbot) 2010-05-05 14:08:42

Repository: asterisk
Revision: 261315

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r261315 | pabelanger | 2010-05-05 14:08:42 -0500 (Wed, 05 May 2010) | 26 lines

Merged revisions 261314 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r261314 | pabelanger | 2010-05-05 14:43:03 -0400 (Wed, 05 May 2010) | 19 lines
 
 Merged revisions 261274 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r261274 | pabelanger | 2010-05-05 12:42:22 -0400 (Wed, 05 May 2010) | 12 lines
   
   Registration fix for SIP realtime.
   
   Make sure realtime fields are not empty.
   
   (closes issue ASTERISK-16034)
   Reported by: Nick_Lewis
   Patches:
         chan_sip.c-realtime.patch uploaded by Nick Lewis (license 657)
   Tested by: Nick_Lewis, sberney
   
   Review: https://reviewboard.asterisk.org/r/643/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=261315
By: Digium Subversion (svnbot) 2010-05-05 14:14:51

Repository: asterisk
Revision: 261317

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r261317 | pabelanger | 2010-05-05 14:14:51 -0500 (Wed, 05 May 2010) | 26 lines

Merged revisions 261314 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r261314 | pabelanger | 2010-05-05 14:43:03 -0400 (Wed, 05 May 2010) | 19 lines
 
 Merged revisions 261274 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r261274 | pabelanger | 2010-05-05 12:42:22 -0400 (Wed, 05 May 2010) | 12 lines
   
   Registration fix for SIP realtime.
   
   Make sure realtime fields are not empty.
   
   (closes issue ASTERISK-16034)
   Reported by: Nick_Lewis
   Patches:
         chan_sip.c-realtime.patch uploaded by Nick Lewis (license 657)
   Tested by: Nick_Lewis, sberney
   
   Review: https://reviewboard.asterisk.org/r/643/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=261317
By: Digium Subversion (svnbot) 2010-05-05 14:19:13

Repository: asterisk
Revision: 261326

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r261326 | pabelanger | 2010-05-05 14:19:13 -0500 (Wed, 05 May 2010) | 26 lines

Merged revisions 261314 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r261314 | pabelanger | 2010-05-05 14:43:03 -0400 (Wed, 05 May 2010) | 19 lines
 
 Merged revisions 261274 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r261274 | pabelanger | 2010-05-05 12:42:22 -0400 (Wed, 05 May 2010) | 12 lines
   
   Registration fix for SIP realtime.
   
   Make sure realtime fields are not empty.
   
   (closes issue ASTERISK-16034)
   Reported by: Nick_Lewis
   Patches:
         chan_sip.c-realtime.patch uploaded by Nick Lewis (license 657)
   Tested by: Nick_Lewis, sberney
   
   Review: https://reviewboard.asterisk.org/r/643/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=261326