| Summary: | ASTERISK-16030: [patch] "queue reset stats" erroneously clears wrapuptime configuration | ||
| Reporter: | Ben Winslow (rain) | Labels: | |
| Date Opened: | 2010-04-29 11:48:22 | Date Closed: | 2010-05-05 10:59:40 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) wrapuptime_reset_fix.diff | |
| Description: | When "queue reset stats" is called, every queue's wrapuptime will be reset to 0, which is obviously the wrong thing. The attached patch resets each member's lastcall to 0 instead, which is probably the intended behavior. ****** STEPS TO REPRODUCE ****** Add a queue with a non-zero wrapuptime and a single agent. Execute "queue reset stats" Enqueue two calls and observe the lack of a wrapup time when the agent hangs up the first. | ||
| Comments: | By: Paul Belanger (pabelanger) 2010-04-29 12:13:46 Thanks for the patch. By: Ben Winslow (rain) 2010-05-04 14:35:34 I've been testing this patch for a few days with no issues. The nightly "queue reset stats" I have cron'd no longer nukes the wrapup time. By: Leif Madsen (lmadsen) 2010-05-04 15:59:33 Setting this to Ready for Review because a few people in the related issue have stated this resolves the issue for them. If someone can take this through the review and commit process, that would be swell! (/me is not necessarily looking in the direction of pabelanger :)) By: Russell Bryant (russell) 2010-05-05 10:14:46 looks right to me, ship it By: Digium Subversion (svnbot) 2010-05-05 10:42:07 Repository: asterisk Revision: 261232 U trunk/apps/app_queue.c ------------------------------------------------------------------------ r261232 | pabelanger | 2010-05-05 10:42:07 -0500 (Wed, 05 May 2010) | 10 lines 'queue reset stats' erroneously clears wrapuptime configuration. Resets each member's lastcall to 0 now. (closes issue ASTERISK-16030) Reported by: rain Patches: wrapuptime_reset_fix.diff uploaded by rain (license 327) Tested by: rain ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=261232 By: Digium Subversion (svnbot) 2010-05-05 10:59:39 Repository: asterisk Revision: 261233 _U branches/1.6.2/ U branches/1.6.2/apps/app_queue.c ------------------------------------------------------------------------ r261233 | pabelanger | 2010-05-05 10:59:38 -0500 (Wed, 05 May 2010) | 17 lines Merged revisions 261232 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r261232 | pabelanger | 2010-05-05 11:42:07 -0400 (Wed, 05 May 2010) | 10 lines 'queue reset stats' erroneously clears wrapuptime configuration. Resets each member's lastcall to 0 now. (closes issue ASTERISK-16030, ASTERISK-15373) Reported by: rain Patches: wrapuptime_reset_fix.diff uploaded by rain (license 327) Tested by: rain ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=261233 | ||