| Summary: | ASTERISK-16001: [patch] Manager cookies isn't compatible with rfc2109 | ||
| Reporter: | Evandro César Arruda (ecarruda) | Labels: | |
| Date Opened: | 2010-04-22 13:44:40 | Date Closed: | 2010-05-17 10:16:55 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/ManagerInterface |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) manager_rfc2109-1.6.2-v1.patch ( 1) manager_rfc2109-trunk-v1.patch | |
| Description: | Manager on all asterisk versions isn't compatible with rfc2109, some http clients return error when try to use cookies with AJAM. The problem is the version paramter, Manager Return: Version: "1" RFC defines: Version:1 I'm sending the patch based on trunk, to asterisk 1.4.30 and 1.6.2.6 | ||
| Comments: | By: Evandro César Arruda (ecarruda) 2010-04-22 13:46:41 Sorry people, Correct information: Manager Return: Version= "1" RFC defines: Version=1 By: Evandro César Arruda (ecarruda) 2010-04-22 13:50:52 on the asterisk 1.4.30 or other 1.4.x version the problem is on http.c for the > 1.6 and trunk is on manager.c Administrator, please, remove the http_rfc2109-1.4.30-v1.patch, it's wrong, i generated wrong, sorry. Thanks guys. By: Evandro César Arruda (ecarruda) 2010-04-22 13:56:48 The Reference Link http://www.ietf.org/rfc/rfc2109.txt By: Leif Madsen (lmadsen) 2010-04-26 12:34:34 Thanks for the patches! I've deleted the one file per your instructions. By: Evandro César Arruda (ecarruda) 2010-04-26 12:59:28 Hey Lmadsen, Thank you for the fast delete and atention. By: Russell Bryant (russell) 2010-04-27 12:32:29 Leif, you can just commit this By: Evandro César Arruda (ecarruda) 2010-04-27 13:04:42 Many thanks Russell. By: Digium Subversion (svnbot) 2010-05-17 09:35:18 Repository: asterisk Revision: 263456 U branches/1.4/main/http.c ------------------------------------------------------------------------ r263456 | lmadsen | 2010-05-17 09:35:18 -0500 (Mon, 17 May 2010) | 11 lines Manager cookies are not compatible with RFC2109. The Version field in the cookies we're setting contain quotes around the version number which is not compatible with RFC2109 and breaks some implementations. (closes issue ASTERISK-16001) Reported by: ecarruda Patches: manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559) manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559) Tested by: ecarruda, russell ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=263456 By: Digium Subversion (svnbot) 2010-05-17 09:37:36 Repository: asterisk Revision: 263457 _U trunk/ U trunk/main/manager.c ------------------------------------------------------------------------ r263457 | lmadsen | 2010-05-17 09:37:35 -0500 (Mon, 17 May 2010) | 19 lines Recorded merge of revisions 263456 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r263456 | lmadsen | 2010-05-17 09:35:18 -0500 (Mon, 17 May 2010) | 11 lines Manager cookies are not compatible with RFC2109. The Version field in the cookies we're setting contain quotes around the version number which is not compatible with RFC2109 and breaks some implementations. (closes issue ASTERISK-16001) Reported by: ecarruda Patches: manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559) manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559) Tested by: ecarruda, russell ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=263457 By: Digium Subversion (svnbot) 2010-05-17 09:41:08 Repository: asterisk Revision: 263458 _U branches/1.6.2/ U branches/1.6.2/main/manager.c ------------------------------------------------------------------------ r263458 | lmadsen | 2010-05-17 09:41:08 -0500 (Mon, 17 May 2010) | 26 lines Merged revisions 263457 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r263457 | lmadsen | 2010-05-17 09:37:35 -0500 (Mon, 17 May 2010) | 19 lines Recorded merge of revisions 263456 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r263456 | lmadsen | 2010-05-17 09:35:18 -0500 (Mon, 17 May 2010) | 11 lines Manager cookies are not compatible with RFC2109. The Version field in the cookies we're setting contain quotes around the version number which is not compatible with RFC2109 and breaks some implementations. (closes issue ASTERISK-16001) Reported by: ecarruda Patches: manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559) manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559) Tested by: ecarruda, russell ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=263458 By: Digium Subversion (svnbot) 2010-05-17 10:14:22 Repository: asterisk Revision: 263460 U trunk/main/manager.c ------------------------------------------------------------------------ r263460 | lmadsen | 2010-05-17 10:14:22 -0500 (Mon, 17 May 2010) | 6 lines Missing newlines added to Set-Cookie line in manager.c Sean Bright pointed out that we lost a set of newline characters in commit 190349 on a line I had recently changed. Yay for code review on commits. (issue ASTERISK-16001) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=263460 By: Digium Subversion (svnbot) 2010-05-17 10:16:55 Repository: asterisk Revision: 263460 U trunk/main/manager.c ------------------------------------------------------------------------ r263460 | lmadsen | 2010-05-17 10:14:22 -0500 (Mon, 17 May 2010) | 7 lines Missing newlines added to Set-Cookie line in manager.c Sean Bright pointed out that we lost a set of newline characters in commit 190349 on a line I had recently changed. Yay for code review on commits. (issue ASTERISK-16001, ASTERISK-10512) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=263460 | ||