[Home]

Summary:ASTERISK-15967: [patch] Suggestion to add Seconds on both cases of Action Status of Manager
Reporter:Evandro César Arruda (ecarruda)Labels:
Date Opened:2010-04-16 07:52:03Date Closed:2011-06-07 14:00:34
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/ManagerInterface/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) manager_actstatus_seconds-1.4-v1.patch
( 1) manager_actstatus_seconds-1.6.0-v1.patch
( 2) manager_actstatus_seconds-1.6.1-v1.patch
( 3) manager_actstatus_seconds-1.6.2-v1.patch
( 4) manager_elapsed_time-v1.patch
Description:People,

I need to request channel by channel when i'm creating dashboard to Queue, because i need to get answered time of member on course calls.

I'm suggesting this patch, i tested and solve my problem.

If need more information on documentation, please, let me know.
Comments:By: Evandro César Arruda (ecarruda) 2010-04-16 07:56:09

Sorry people, i missed that on Description.

To solve this, i wrote a patch on action_status method changend cdr verification and putting elapsed_seconds on all manager returns.

On the default Mananager we don't have Seconds on Bridged channel, with this patch we have, because using core show channel we have too.

I'm sending patch suggest to Asterisk versions: 1.4, 1.6.0.x, 1.6.1.x 1.6.2.X

By: Paul Belanger (pabelanger) 2010-04-16 08:16:23

Thanks for you patch. It should be noted that any new features will have to be patched against trunk.

Also you will need to document any changes in UPGRADE.txt and CHANGES for manager events.

By: Evandro César Arruda (ecarruda) 2010-04-19 13:26:45

pabelanger,

Thanks and sorry about my error, i never send feature request, just bug report and patchs.

Please see my new file and give me directions to do it.

Thank you

By: Evandro César Arruda (ecarruda) 2010-04-19 13:29:02

lmadsen,

Thank you, i uploaded new file with the requests bu pabelanger, prease check this for me.

Thanks,
Evandro

By: Leif Madsen (lmadsen) 2010-04-19 13:55:42

John Todd and I were wondering if it would make sense to move this down to milliseconds? The granularity would probably be appreciated by someone in the future :)

By: Evandro César Arruda (ecarruda) 2010-04-19 15:09:22

Well,

Lmadsen, i'm thinking and talket with another members of my Dev Team.

The most part of the people using ajam have latency bigger than 10ms, all my requests have 1 second of interval, my small interval have 500ms, i don't no if the good idea tell to the peoples: Now is necessary to give the value and apply rules to divide by 1000 and round the value, the more part of the times we will have 0 or 1 second, humm, i don't know, i don't have any application to use this.

The second thing is: the most part of the time report on asterisk are in seconds, humm, but, to the future thinking on someone need this, ok, it's the moment to make the future easy ehehe.

Thank you for request my opinion about this, it's a pleasure to me.

By: Leif Madsen (lmadsen) 2010-04-21 08:29:03

OK that makes sense to me. I say we just leave it as seconds for now. If someone really needs this to be in milliseconds than we can change it later.

By: Evandro César Arruda (ecarruda) 2010-04-22 07:33:03

lmadsen,

It was a pleasure discussing this with you. I am available should they need to discuss something else or
need some help. Sorry for my english, isn't very good.

And i agree, give in second is the best choise now. :D

By: Evandro César Arruda (ecarruda) 2010-05-06 08:12:09

lmadsen,

Can i add a new update propose on the same part of the manager hear, or i need to open a new issue to do this?

Because on svn trunk don't have this update on this momment to work on new diff.

Thanks

By: Leif Madsen (lmadsen) 2010-05-10 11:10:14

Ummm, I'm not sure what you're proposing, so I'm not sure :)  Add it for now, and if the developer feels it is two separate things in the same patch he may request you to open a new issue.

By: Tilghman Lesher (tilghman) 2010-05-13 17:08:13

You can actually already get this behavior with no patch at all, by changing manager.conf to specify:

channelvars=CDR(duration)

You then get the following output added to every manager event:
ChanVariable(SIP/123-00000001): CDR(duration)=5

where the channel name is specified in the parentheses, and the duration is specified in seconds.

By: Evandro César Arruda (ecarruda) 2010-05-14 11:27:39

tilghman,

My patch refer to HTTP ( ajam ) request, see on http action status, we have elapsed seconds just on one side of the channel, but, the main channel on incomming calls, can be something waiting on queue, and when i need the time answered for example, i need to get the time on bridged channel.

Please give some atention on this, i patched all my asterisk versions to use it, i'm don't using events on port 5038, i'm talking about http requests.

Thanks man.


By: Evandro César Arruda (ecarruda) 2010-05-14 11:29:20

tilghman,

I now, i now, about channelvars requests, in ajam we can do it too, but we have elapsed time on one side of the channel, don't have anything stopping us to put eleapsed time on bridge channel too.

We have on one side, we can put on second side of the bridge :D

By: Tilghman Lesher (tilghman) 2010-05-17 16:13:02

You can already get events on the HTTP side, by using Action: WaitEvent.