[Home]

Summary:ASTERISK-15959: [patch] OOH323 Outgoing Call Fails if Originated from a DAHDI Extension
Reporter:Vladimir Mikhelson (vmikhelson)Labels:
Date Opened:2010-04-15 01:10:51Date Closed:2011-04-12 08:47:05
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Addons/chan_ooh323
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) h323_log.zip
( 1) zero_callerid_num.patch
Description:A call originated from a DAHDI extension on Asterisk 1.6.2.6 rings indefinitely. The destination end point, Avaya IPOffice 403, does not show a call in its monitor. After the call is hung, the following shows up in Avaya monitor:
5272909mS H323Rx: src=172.17.137.11:12032
           H323 Pcol=08(Q931) Reflen=2 ref=004B(Remote)
           Message Type = ReleaseComplete

5272910mS PRN: Could not decode field index 51 + 0
5272910mS PRN: H225.0 Decode Failure!
5272911mS PRN: BUF ff029570 : data=ff08a056 , length = 34
5272911mS PRN: 0000 25 c0 05 00 08 91 4a 00 04 58 88 00 11 00 6f 6f %....J..X....oo
5272912mS PRN: 0010 68 33 32 33 63 2d 02 9b 74 00 00 00 00 00 10 80 h323c-..t.......
5272912mS PRN: 0020 01 80                                           ..
5272912mS PRN: Buf2Sys failed 'Decode failed!'

h323_log shows ASN1 Errors and "Unbalanced Structure" errors.

Logs attached.



****** ADDITIONAL INFORMATION ******

SIP calls go through just fine.

After Asterisk reload the first call from DAHDI extension succeeds.

Avaya Monitor shows the following message sequence once every 1-2 seconds:

3705933mS H245Tx: v=1 peb=9
           MultimediaSystemControlMessage = request = roundTripDelayRequest

3705934mS H323Tx: dst=172.17.137.11:12039
           H323 Pcol=08(Q931) Reflen=2 ref=002C(Local)
           Message Type = Facility

3706116mS H323Rx: src=172.17.137.11:12039
           H323 Pcol=08(Q931) Reflen=2 ref=002C(Remote)
           Message Type = Facility

3706117mS PRN: Unhandled Facility
3706117mS H245Rx: v=1 peb=9
           MultimediaSystemControlMessage = response = roundTripDelayResponse
Comments:By: Vladimir Mikhelson (vmikhelson) 2010-04-15 02:30:12

Can be related to issue 0016968.
By: Vladimir Mikhelson (vmikhelson) 2010-04-15 22:43:18

It was related to the issue 0016968.

Built Asterisk SVN-branch-1.6.2-r257265. That fixed DAHDI issue and in turn it fixed the OOH323 issue.

The case can be closed now.

Note: Asterisk 1.6.2.6 + Addons 1.6.2.0 packages deliver OOH323 channel in non usable state. Building just Addons from the trunk does not help since then we run into the DAHDI related problem I have described here.
By: Alexander Anikin (may213) 2010-04-17 16:32:51

Seen in log:

00:27:06:756  Added local alias  to call. (outgoing, ooh323c_o_3)

and after

00:27:06:874  Built SETUP message (outgoing, ooh323c_o_3)
00:27:06:874  Asn1Error: -23 at ooh323c/src/encode.c:516
00:27:06:874  Asn1Error: -23 at ooh323c/src/encode.c:969
00:27:06:874  Asn1Error: -23 at ooh323c/src/encode.c:237
00:27:06:874  ERROR: UserInfo encoding failed
00:27:06:874  Error:Failed to encode uuie. (outgoing, ooh323c_o_3)
00:27:06:874  Error:Failed to encode H225 message. (outgoing, ooh323c_o_3)
00:27:06:874  Error:Failed to enqueue SETUP message to outbound queue. (outgoing, ooh323c_o_3)

seems like to incorrect alias added to h323 call alias fields.
Also need to think about hangup sending in this case, we can't send setup due to incorrect encoding but we try send hangup to close non-opened call.
By: Alexander Anikin (may213) 2010-04-18 15:22:11

Vladimir, please try attached patch. It's for 1.6.2 version but it's simple and same patch can be applied to any 1.6.* and trunk version.
By: Vladimir Mikhelson (vmikhelson) 2010-04-19 23:21:00

Installed Addons 1.6.2.1 binaries, they would not work with Asterisk SVN-branch-1.6.2-r257265. I would get "All Circuits are Busy" when trying to use OOH323 channel.

Re-compiled Addons from the 1.6.2 branch. Everything worked fine.

Applied the patch. Everything still worked fine. No difference from a user's perspective.

Please advise how to test.
By: Alexander Anikin (may213) 2010-04-25 13:20:20

Bug is solved by the patch in my environment, so i'll close this.
Please reopen if it will occur again.
By: Digium Subversion (svnbot) 2010-04-25 13:29:30

Repository: asterisk-addons
Revision: 1110

U   branches/1.6.0/channels/chan_ooh323.c

------------------------------------------------------------------------
r1110 | may | 2010-04-25 13:29:29 -0500 (Sun, 25 Apr 2010) | 12 lines

Don't pass zero length callerid to ooh323 stack

Don't pass zero callerid string to ooh323 stack because it can't encode this properly and
can't generate setup message.

(issue ASTERISK-15959)
Reported by: vmikhelson
Patches:
     zero_callerid_num.patch uploaded by may213 (license 454)
Tested by: may213


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1110
By: Digium Subversion (svnbot) 2010-04-25 13:31:58

Repository: asterisk-addons
Revision: 1111

U   branches/1.6.1/channels/chan_ooh323.c

------------------------------------------------------------------------
r1111 | may | 2010-04-25 13:31:57 -0500 (Sun, 25 Apr 2010) | 12 lines

Don't pass zero length callerid to ooh323 stack

Don't pass zero callerid string to ooh323 stack because it can't encode this properly and
can't generate setup message.

(issue ASTERISK-15959)
Reported by: vmikhelson
Patches:
     zero_callerid_num.patch uploaded by may213 (license 454)
Tested by: may213


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1111
By: Digium Subversion (svnbot) 2010-04-25 13:32:54

Repository: asterisk-addons
Revision: 1112

U   branches/1.6.2/channels/chan_ooh323.c

------------------------------------------------------------------------
r1112 | may | 2010-04-25 13:32:54 -0500 (Sun, 25 Apr 2010) | 12 lines

Don't pass zero length callerid to ooh323 stack

Don't pass zero callerid string to ooh323 stack because it can't encode this properly and
can't generate setup message.

(issue ASTERISK-15959)
Reported by: vmikhelson
Patches:
     zero_callerid_num.patch uploaded by may213 (license 454)
Tested by: may213


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1112
By: Digium Subversion (svnbot) 2010-04-25 13:34:29

Repository: asterisk
Revision: 258838

U   trunk/addons/chan_ooh323.c

------------------------------------------------------------------------
r258838 | may | 2010-04-25 13:34:29 -0500 (Sun, 25 Apr 2010) | 12 lines

Don't pass zero length callerid to ooh323 stack

Don't pass zero callerid string to ooh323 stack because it can't encode this properly and
can't generate setup message.

(closes issue ASTERISK-15959)
Reported by: vmikhelson
Patches:
     zero_callerid_num.patch uploaded by may213 (license 454)
Tested by: may213


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=258838
By: Vladimir Mikhelson (vmikhelson) 2010-05-05 22:11:14

May,

I finally had a chance to test your patch.

1. Applied current Asterisk 1.6.2.7 + Asterisk-Addons 1.6.2.1 distributed to AsteriskNOW users as of 05/04/2010.

2. Observed outgoing calls on OOH323 from DAHDI succeeding only on the first call after the Asterisk load as DAHDI had been loosing CallerID after the first call completion. Observed the following in the log:

09:51:55:584  ERROR: unbalanced structure
09:51:55:584  Added TX fs element 2 with capability OO_G711ULAW64K(outgoing, ooh323c_o_4)
09:51:55:584  Added 2 fast start elements to SETUP message (outgoing, ooh323c_o_4)
09:51:55:585  Built SETUP message (outgoing, ooh323c_o_4)
09:51:55:585  Asn1Error: -23 at ooh323c/src/encode.c:516
09:51:55:585  Asn1Error: -23 at ooh323c/src/encode.c:969
09:51:55:585  Asn1Error: -23 at ooh323c/src/encode.c:237
09:51:55:585  ERROR: UserInfo encoding failed
09:51:55:585  Error:Failed to encode uuie. (outgoing, ooh323c_o_4)
09:51:55:585  Error:Failed to encode H225 message. (outgoing, ooh323c_o_4)
09:51:55:585  Error:Failed to enqueue SETUP message to outbound queue. (outgoing, ooh323c_o_4)
09:51:55:585  In ooEndCall call state is - OO_CALL_CLEAR_RELEASESENT (outgoing, ooh323c_o_3)
09:51:55:685  In ooEndCall call state is - OO_CALL_CLEAR_RELEASESENT (outgoing, ooh323c_o_3)
09:51:55:785  In ooEndCall call state is - OO_CALL_CLEAR_RELEASESENT (outgoing, ooh323c_o_3)
09:51:55:885  In ooEndCall call state is - OO_CALL_CLEAR_RELEASESENT (outgoing, ooh323c_o_3)
09:51:55:985  In ooEndCall call state is - OO_CALL_CLEAR_RELEASESENT (outgoing, ooh323c_o_3)
09:51:56:085  In ooEndCall call state is - OO_CALL_CLEAR_RELEASESENT (outgoing, ooh323c_o_3)

3. Installed the patched OOH323 channel. Observed DAHDI to OOH323 calls being placed normally.

Thank you for your work.

-Vladimir

By: Leif Madsen (lmadsen) 2011-04-12 08:47:04

Closing this again as it was already fixed. Thanks!